Skip to content

Commit a3a9d1e

Browse files
committed
use another promotion mechanism for CloseOpen & co.
1 parent dbc6254 commit a3a9d1e

2 files changed

Lines changed: 11 additions & 8 deletions

File tree

src/distributions.jl

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -219,17 +219,17 @@ OpenOpen(a::T, b::T) where {T<:AbstractFloat} = OpenOpenAB{T}(a, b)
219219

220220
# convenience functions
221221

222-
CloseOpen(a, b) = CloseOpen(AbstractFloat(a), AbstractFloat(b))
223-
CloseOpen(a::AbstractFloat, b::AbstractFloat) = CloseOpen(promote(a, b)...)
222+
CloseOpen(a, b) = CloseOpen(promote(a, b)...)
223+
CloseOpen(a::T, b::T) where {T} = CloseOpen(AbstractFloat(a), AbstractFloat(b))
224224

225-
OpenClose(a, b) = OpenClose(AbstractFloat(a), AbstractFloat(b))
226-
OpenClose(a::AbstractFloat, b::AbstractFloat) = OpenClose(promote(a, b)...)
225+
OpenClose(a, b) = OpenClose(promote(a, b)...)
226+
OpenClose(a::T, b::T) where {T} = OpenClose(AbstractFloat(a), AbstractFloat(b))
227227

228-
CloseClose(a, b) = CloseClose(AbstractFloat(a), AbstractFloat(b))
229-
CloseClose(a::AbstractFloat, b::AbstractFloat) = CloseClose(promote(a, b)...)
228+
CloseClose(a, b) = CloseClose(promote(a, b)...)
229+
CloseClose(a::T, b::T) where {T} = CloseClose(AbstractFloat(a), AbstractFloat(b))
230230

231-
OpenOpen(a, b) = OpenOpen(AbstractFloat(a), AbstractFloat(b))
232-
OpenOpen(a::AbstractFloat, b::AbstractFloat) = OpenOpen(promote(a, b)...)
231+
OpenOpen(a, b) = OpenOpen(promote(a, b)...)
232+
OpenOpen(a::T, b::T) where {T} = OpenOpen(AbstractFloat(a), AbstractFloat(b))
233233

234234
## Bernoulli
235235

test/runtests.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -269,6 +269,9 @@ end
269269
for CO in (CloseOpen, CloseClose, OpenOpen, OpenClose)
270270
@test_throws ArgumentError CO(1, 1)
271271
@test_throws ArgumentError CO(2, 1)
272+
273+
@test CO(Float16(1), 2) isa CO{Float16}
274+
@test CO(1, Float32(2)) isa CO{Float32}
272275
end
273276
end
274277

0 commit comments

Comments
 (0)