disable rand(String, 2, 3)

Author: rfourquet

src/containers.jl

@@ -65,6 +65,15 @@ end
 
 @make_container(::Type{String}, [n::Integer])
 
+# we disable smthg like rand(String, 2, 3) because it looks to similar to, but is too different
+# than, rand(String, 2) (Array of String vs String)
+
+string_error() = throw(ArgumentError(
+ "rand([rng], String, d1::Integer, d2::Integer, ...) is unsupported,
+ use rand(rng, make(String), d1, d2, ...) or rand(rng, String, (d1, d2, ...)) instead"))
+rand(rng::AbstractRNG, ::Type{String}, n::Integer...) = string_error()
+rand(                  ::Type{String}, n::Integer...) = string_error()
+
 # sparse vectors & matrices
 @make_container(::Type{SparseVector},    p::AbstractFloat, m::Integer)
 @make_container(::Type{SparseVector},    p::AbstractFloat, d::Dims{1})

test/runtests.jl

@@ -189,6 +189,9 @@ const spString = Sampler(MersenneTwister, String)
     s = rand(rng..., "asd", String)
     @test length(s) == 8
     @test Set(s) <= Set("asd")
+    @test_throws ArgumentError rand(rng..., String, 2, 3)
+    @test_throws ArgumentError rand(rng..., String, 2, 3, 4)
+    @test_throws ArgumentError rand(rng..., String, 2, 3, 4, 5)
 
     # Tuple
     s = rand(rng..., Int, NTuple{3})