Merge pull request #657 from JuliaDiff/ox/fix_ci

oxinabox · web-flow · commit d2b4b9407eef · 2024-01-30T13:44:53.000+08:00
Restrict kwarg type in code generated by @non_differentiable macro
diff --git a/Project.toml b/Project.toml
@@ -1,6 +1,6 @@
 name = "ChainRulesCore"
 uuid = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
-version = "1.20.0"
+version = "1.20.1"
 
 [deps]
 Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"
diff --git a/src/rule_definition_tools.jl b/src/rule_definition_tools.jl
@@ -445,7 +445,7 @@ function _nondiff_rrule_expr(__source__, primal_sig_parts, primal_invoke)
     return @strip_linenos quote
         # Manually defined kw version to save compiler work. See explanation in rules.jl
         function (::Core.kwftype(typeof(rrule)))(
-            $(esc(kwargs))::Any, ::typeof(rrule), $(esc_primal_sig_parts...)
+            $(esc(kwargs))::NamedTuple, ::typeof(rrule), $(esc_primal_sig_parts...)
         )
             return ($(esc(_with_kwargs_expr(primal_invoke, kwargs))), $pullback_expr)
         end

Original file line number	Diff line number	Diff line change
`@@ -445,7 +445,7 @@ function _nondiff_rrule_expr(__source__, primal_sig_parts, primal_invoke)`
`445`	`445`	`return @strip_linenos quote`
`446`	`446`	`# Manually defined kw version to save compiler work. See explanation in rules.jl`
`447`	`447`	`function (::Core.kwftype(typeof(rrule)))(`
`448`		`- $(esc(kwargs))::Any, ::typeof(rrule), $(esc_primal_sig_parts...)`
	`448`	`+ $(esc(kwargs))::NamedTuple, ::typeof(rrule), $(esc_primal_sig_parts...)`
`449`	`449`	`)`
`450`	`450`	`return ($(esc(_with_kwargs_expr(primal_invoke, kwargs))), $pullback_expr)`
`451`	`451`	`end`