Skip to content

Commit 128ae3b

Browse files
committed
less logs
1 parent b1827a2 commit 128ae3b

4 files changed

Lines changed: 14 additions & 15 deletions

File tree

src/main/java/fr/jmmc/oitools/fits/FitsTable.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1042,7 +1042,7 @@ protected final Map<String, Object> getColumnsRangeValue() {
10421042
* Return the column range given its name
10431043
*
10441044
* @param name column name
1045-
* @return Range instance
1045+
* @return Range instance or Range.UNDEFINED_RANGE if no data
10461046
*/
10471047
public Range getColumnRange(final String name) {
10481048
final String key = name + "_RANGE";

src/main/java/fr/jmmc/oitools/model/OIData.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -979,14 +979,14 @@ public final Range getMjdRange() {
979979
* Return the column range given its name
980980
*
981981
* @param name column name
982-
* @return Range instance
982+
* @return Range instance or Range.UNDEFINED_RANGE if no data
983983
*/
984984
public final Range getColumnRange(final String name) {
985985
// Intercept EFF_WAVE and EFF_BAND to use OI_WAVELENGTH:
986986
if (OIFitsConstants.COLUMN_EFF_WAVE.equals(name)
987987
|| OIFitsConstants.COLUMN_EFF_BAND.equals(name)) {
988988
final OIWavelength oiWavelength = getOiWavelength();
989-
return (oiWavelength != null) ? oiWavelength.getColumnRange(name) : null;
989+
return (oiWavelength != null) ? oiWavelength.getColumnRange(name) : Range.UNDEFINED_RANGE;
990990
}
991991
return super.getColumnRange(name);
992992
}

src/main/java/fr/jmmc/oitools/model/OIDataListHelper.java

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ public static List<String> getDistinctStaConfs(final Collection<OIData> oiDataLi
162162
* Return the global column range from given OIData tables
163163
* @param oiDataList OIData tables
164164
* @param name column name to extract values
165-
* @return global column range or Range.UNDEFINED_RANGE when nothing found
165+
* @return Range instance or Range.UNDEFINED_RANGE if no data
166166
*/
167167
public static Range getColumnRange(final Collection<OIData> oiDataList, final String name) {
168168
double min = Double.POSITIVE_INFINITY;
@@ -180,11 +180,8 @@ public static Range getColumnRange(final Collection<OIData> oiDataList, final St
180180
}
181181
}
182182
}
183-
184183
final Range range = (min < max) ? new Range(min, max) : Range.UNDEFINED_RANGE;
185-
186-
logger.log(Level.WARNING, "getColumnRange : {0}", range);
187-
184+
logger.log(Level.FINE, "getColumnRange : {0}", range);
188185
return range;
189186
}
190187

src/main/java/fr/jmmc/oitools/model/OIFitsCollection.java

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -449,7 +449,7 @@ public List<String> getDistinctValues(final String name) {
449449
/**
450450
* Return the global column range from all OIData tables
451451
* @param name column name to extract values
452-
* @return global column range or Range.UNDEFINED_RANGE when nothing found
452+
* @return global column range or Range.UNDEFINED_RANGE if no data
453453
*/
454454
public Range getColumnRange(final String name) {
455455
Range r = columnRanges.get(name);
@@ -537,9 +537,7 @@ public SelectorResult findOIData(final Selector selector, final SelectorResult i
537537
filtersData1D.add(new Double1DFilter(e.getKey(), (List<Range>) e.getValue()));
538538
}
539539
}
540-
if (logger.isLoggable(Level.INFO)) {
541-
logger.log(Level.INFO, "filtersData1D: {0} ", filtersData1D);
542-
}
540+
logger.log(Level.FINE, "filtersData1D: {0} ", filtersData1D);
543541
}
544542
{
545543
// Wavelength filters:
@@ -552,6 +550,7 @@ public SelectorResult findOIData(final Selector selector, final SelectorResult i
552550
filtersWL.add(new Double1DFilter(e.getKey(), (List<Range>) e.getValue()));
553551
}
554552
}
553+
logger.log(Level.FINE, "filtersWL: {0} ", filtersWL);
555554
}
556555
}
557556

@@ -673,9 +672,8 @@ private void filterOIData(final SelectorResult result, final Granule g, final OI
673672
private IndexMask computeMask1D(final List<FitsTableFilter<?>> filters,
674673
final FitsTable fitsTable,
675674
final List<FitsTableFilter<?>> usedFilters) {
676-
if (logger.isLoggable(Level.FINE)) {
677-
logger.log(Level.FINE, "computeMask1D: filters = {0}", filters);
678-
}
675+
676+
logger.log(Level.FINE, "computeMask1D: filters = {0}", filters);
679677

680678
FilterState chainState = FilterState.FULL;
681679
usedFilters.clear();
@@ -686,6 +684,10 @@ private IndexMask computeMask1D(final List<FitsTableFilter<?>> filters,
686684
// Prepare filter:
687685
final FilterState state = filter.prepare(fitsTable);
688686

687+
if (logger.isLoggable(Level.FINE)) {
688+
logger.log(Level.FINE, "{0} => {1}", new Object[]{filter, state});
689+
}
690+
689691
if (state.ordinal() < chainState.ordinal()) {
690692
// min:
691693
chainState = state;

0 commit comments

Comments
 (0)