Fix StackOverflow in test_functools (#1508)

* Fix StackOverflow in test_functools

* Update test_resource_stdlib

* Disable failing test on Mono

Author: slozier

Src/IronPython.Modules/_functools.cs

@@ -193,21 +193,33 @@ public void __setstate__(CodeContext context, [NotNone] PythonTuple state) {
             }
 
             public string __repr__(CodeContext context) {
-                var builder = new StringBuilder();
-                builder.Append("functools.partial(");
-                builder.Append(PythonOps.Repr(context, func));
-                foreach (var x in _args) {
-                    builder.Append(", ");
-                    builder.Append(PythonOps.Repr(context, x));
+                var infinite = PythonOps.GetAndCheckInfinite(this);
+                if (infinite == null) {
+                    return "...";
                 }
-                foreach (var p in _keywordArgs) {
-                    builder.Append(", ");
-                    builder.Append(p.Key);
-                    builder.Append('=');
-                    builder.Append(PythonOps.Repr(context, p.Value));
+
+                int infiniteIndex = infinite.Count;
+                infinite.Add(this);
+                try {
+                    var builder = new StringBuilder();
+                    builder.Append("functools.partial(");
+                    builder.Append(PythonOps.Repr(context, func));
+                    foreach (var x in _args) {
+                        builder.Append(", ");
+                        builder.Append(PythonOps.Repr(context, x));
+                    }
+                    foreach (var p in _keywordArgs) {
+                        builder.Append(", ");
+                        builder.Append(p.Key);
+                        builder.Append('=');
+                        builder.Append(PythonOps.Repr(context, p.Value));
+                    }
+                    builder.Append(')');
+                    return builder.ToString();
+                } finally {
+                    System.Diagnostics.Debug.Assert(infiniteIndex == infinite.Count - 1);
+                    infinite.RemoveAt(infiniteIndex);
                 }
-                builder.Append(')');
-                return builder.ToString();
             }
 
             #endregion

Tests/modules/system_related/test_resource_stdlib.py

@@ -25,6 +25,7 @@ def load_tests(loader, standard_tests, pattern):
         suite.addTest(test.test_resource.ResourceTest('test_linux_constants'))
         suite.addTest(test.test_resource.ResourceTest('test_pagesize'))
         suite.addTest(test.test_resource.ResourceTest('test_prlimit'))
+        suite.addTest(test.test_resource.ResourceTest('test_prlimit_refcount'))
         suite.addTest(test.test_resource.ResourceTest('test_setrusage_refcount'))
         return suite
 

Tests/test_functools_stdlib.py

@@ -90,7 +90,7 @@ def load_tests(loader, standard_tests, pattern):
         suite.addTest(test.test_functools.TestPartialC('test_positional'))
         suite.addTest(test.test_functools.TestPartialC('test_protection_of_callers_dict_argument'))
         #suite.addTest(test.test_functools.TestPartialC('test_recursive_pickle')) # StackOverflowException
-        #suite.addTest(unittest.expectedFailure(test.test_functools.TestPartialC('test_recursive_repr'))) # StackOverflowException, was: AssertionError: '<CPartialSubclass object at 0x00000000000000C0>' != 'CPartialSubclass(...)'
+        suite.addTest(test.test_functools.TestPartialC('test_recursive_repr'))
         suite.addTest(test.test_functools.TestPartialC('test_repr'))
         suite.addTest(unittest.expectedFailure(test.test_functools.TestPartialC('test_setstate'))) # AssertionError: Tuples differ: (<function capture at 0x000000000000008D>, (1,), {'a': 10}, {'attr': []}) != (<function capture at 0x000000000000008D>, (1,), {'a': 10}, {})
         suite.addTest(test.test_functools.TestPartialC('test_setstate_errors'))
@@ -117,13 +117,14 @@ def load_tests(loader, standard_tests, pattern):
         suite.addTest(test.test_functools.TestPartialCSubclass('test_positional'))
         suite.addTest(test.test_functools.TestPartialCSubclass('test_protection_of_callers_dict_argument'))
         #suite.addTest(test.test_functools.TestPartialCSubclass('test_recursive_pickle')) # StackOverflowException
-        #suite.addTest(unittest.expectedFailure(test.test_functools.TestPartialCSubclass('test_recursive_repr'))) # StackOverflowException, was: AssertionError: '<CPartialSubclass object at 0x00000000000000C0>' != 'CPartialSubclass(...)'
+        suite.addTest(unittest.expectedFailure(test.test_functools.TestPartialCSubclass('test_recursive_repr'))) # AssertionError: 'functools.partial(...)' != 'CPartialSubclass(...)'
         suite.addTest(unittest.expectedFailure(test.test_functools.TestPartialCSubclass('test_repr'))) # AssertionError
         suite.addTest(unittest.expectedFailure(test.test_functools.TestPartialCSubclass('test_setstate'))) # AssertionError: Tuples differ: (<function capture at 0x000000000000008D>, (1,), {'a': 10}, {'attr': []}) != (<function capture at 0x000000000000008D>, (1,), {'a': 10}, {})
         suite.addTest(test.test_functools.TestPartialCSubclass('test_setstate_errors'))
         suite.addTest(test.test_functools.TestPartialCSubclass('test_setstate_refcount'))
         suite.addTest(unittest.expectedFailure(test.test_functools.TestPartialCSubclass('test_setstate_subclasses'))) # AssertionError: <class 'test.test_functools.MyDict'> is not <class 'dict'>
-        suite.addTest(test.test_functools.TestPartialCSubclass('test_weakref'))
+        if not is_mono:
+            suite.addTest(test.test_functools.TestPartialCSubclass('test_weakref'))
         suite.addTest(test.test_functools.TestPartialCSubclass('test_with_bound_and_unbound_methods'))
         suite.addTest(test.test_functools.TestPartialMethod('test_abstract'))
         suite.addTest(test.test_functools.TestPartialMethod('test_arg_combinations'))