Skip to content

Commit 37bf778

Browse files
committed
Disable more tests
1 parent 7da55d7 commit 37bf778

3 files changed

Lines changed: 15 additions & 6 deletions

File tree

Src/IronPythonTest/Cases/CPythonCasesManifest.ini

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1281,6 +1281,9 @@ Ignore=true # TypeError: maketrans() takes at least 2 arguments (1 given)
12811281
[CPython.test_smtpnet]
12821282
Ignore=true # unittest.case.SkipTest: Cannot import name SSLSession
12831283

1284+
[CPython.test_spwd]
1285+
Ignore=true # fails on macOS
1286+
12841287
[CPython.test_string]
12851288
Ignore=true # test_invalid_placeholders
12861289

Src/StdLib/Lib/subprocess.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1293,6 +1293,9 @@ def _communicate(self, input, endtime, orig_timeout):
12931293

12941294
def terminate(self):
12951295
"""Terminates the process."""
1296+
# Don't terminate a process that we know has already died.
1297+
if self.returncode is not None:
1298+
return
12961299
self._handle.Kill()
12971300

12981301
kill = terminate

Src/StdLib/Lib/test/test_urlparse.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1074,19 +1074,22 @@ def test_urlsplit_normalization(self):
10741074
self.assertIn('\u2100', denorm_chars)
10751075
self.assertIn('\uFF03', denorm_chars)
10761076

1077-
# bpo-36742: Verify port separators are ignored when they
1078-
# existed prior to decomposition
1079-
urllib.parse.urlsplit('http://\u30d5\u309a:80')
1080-
with self.assertRaises(ValueError):
1081-
urllib.parse.urlsplit('http://\u30d5\u309a\ufe1380')
1082-
10831077
# https://github.com/IronLanguages/ironpython3/issues/614
10841078
is_mono = False
10851079
mono_issue_chars = ("\ufe13", "\ufe16", "\ufe5f")
10861080
if sys.implementation.name == "ironpython":
10871081
import clr
10881082
is_mono = clr.IsMono
10891083

1084+
# bpo-36742: Verify port separators are ignored when they
1085+
# existed prior to decomposition
1086+
urllib.parse.urlsplit('http://\u30d5\u309a:80')
1087+
if is_mono:
1088+
urllib.parse.urlsplit('http://\u30d5\u309a\ufe1380')
1089+
else:
1090+
with self.assertRaises(ValueError):
1091+
urllib.parse.urlsplit('http://\u30d5\u309a\ufe1380')
1092+
10901093
for scheme in ["http", "https", "ftp"]:
10911094
for netloc in ["netloc{}false.netloc", "n{}user@netloc"]:
10921095
for c in denorm_chars:

0 commit comments

Comments
 (0)