Skip to content

Commit c4f2496

Browse files
Add TODO with incorrect logic in reductions_over_axis.hpp
1 parent ad814fb commit c4f2496

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

dpctl_ext/tensor/libtensor/source/reductions/reduction_over_axis.hpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -328,6 +328,7 @@ std::pair<sycl::event, sycl::event> py_reduction_over_axis(
328328
using dpctl::tensor::py_internal::simplify_iteration_space;
329329
using dpctl::tensor::py_internal::simplify_iteration_space_1;
330330

331+
// TODO: not used anywhere
331332
auto const &src_shape_vecs = src.get_shape_vector();
332333
auto const &src_strides_vecs = src.get_strides_vector();
333334
auto const &dst_strides_vecs = dst.get_strides_vector();
@@ -927,6 +928,7 @@ std::pair<sycl::event, sycl::event> py_search_over_axis(
927928
shT compact_reduction_src_strides;
928929
py::ssize_t reduction_src_offset(0);
929930

931+
// TODO: not used anywhere
930932
compact_iteration_space(
931933
reduction_nd, reduction_shape_ptr, reduction_src_strides,
932934
// output
@@ -1157,6 +1159,7 @@ std::pair<sycl::event, sycl::event>
11571159
bool is_src_f_contig = src.is_f_contiguous();
11581160
bool is_dst_c_contig = dst.is_c_contiguous();
11591161

1162+
// TODO: should be dst_nelems == 0?
11601163
if ((is_src_c_contig && is_dst_c_contig) ||
11611164
(is_src_f_contig && dst_nelems == 0))
11621165
{

0 commit comments

Comments
 (0)