Merge pull request #1975 from IntelPython/further-remove-const-members-of-class-and-structs

Remove const qualifiers for class/struct members per C++ guidelines

Author: ndgrigorian

dpctl/tensor/libtensor/include/kernels/boolean_advanced_indexing.hpp

@@ -116,15 +116,15 @@ struct MaskedExtractStridedFunctor
     const dataT *src = nullptr;
     const indT *cumsum = nullptr;
     dataT *dst = nullptr;
-    const std::size_t masked_nelems = 0;
+    std::size_t masked_nelems = 0;
     // has nd, shape, src_strides, dst_strides for
     // dimensions that ARE NOT masked
-    const OrthogIndexerT orthog_src_dst_indexer;
+    OrthogIndexerT orthog_src_dst_indexer;
     // has nd, shape, src_strides for
     // dimensions that ARE masked
-    const MaskedSrcIndexerT masked_src_indexer;
+    MaskedSrcIndexerT masked_src_indexer;
     // has 1, dst_strides for dimensions that ARE masked
-    const MaskedDstIndexerT masked_dst_indexer;
+    MaskedDstIndexerT masked_dst_indexer;
     LocalAccessorT lacc;
 };
 
@@ -198,15 +198,15 @@ struct MaskedPlaceStridedFunctor
     dataT *dst = nullptr;
     const indT *cumsum = nullptr;
     const dataT *rhs = nullptr;
-    const std::size_t masked_nelems = 0;
+    std::size_t masked_nelems = 0;
     // has nd, shape, dst_strides, rhs_strides for
     // dimensions that ARE NOT masked
-    const OrthogIndexerT orthog_dst_rhs_indexer;
+    OrthogIndexerT orthog_dst_rhs_indexer;
     // has nd, shape, dst_strides for
     // dimensions that ARE masked
-    const MaskedDstIndexerT masked_dst_indexer;
+    MaskedDstIndexerT masked_dst_indexer;
     // has 1, rhs_strides for dimensions that ARE masked
-    const MaskedRhsIndexerT masked_rhs_indexer;
+    MaskedRhsIndexerT masked_rhs_indexer;
     LocalAccessorT lacc;
 };
 

dpctl/tensor/libtensor/include/kernels/clip.hpp

@@ -245,7 +245,7 @@ template <typename T, typename IndexerT> class ClipStridedFunctor
     const T *min_p = nullptr;
     const T *max_p = nullptr;
     T *dst_p = nullptr;
-    const IndexerT indexer;
+    IndexerT indexer;
 
 public:
     ClipStridedFunctor(const T *x_p_,

dpctl/tensor/libtensor/include/kernels/constructors.hpp

@@ -260,8 +260,8 @@ template <typename Ty, typename IndexerT> class FullStridedFunctor
 {
 private:
     Ty *p = nullptr;
-    const Ty fill_v;
-    const IndexerT indexer;
+    Ty fill_v;
+    IndexerT indexer;
 
 public:
     FullStridedFunctor(Ty *p_, const Ty &fill_v_, const IndexerT &indexer_)

dpctl/tensor/libtensor/include/kernels/copy_and_cast.hpp

@@ -87,7 +87,7 @@ class GenericCopyFunctor
 private:
     const srcT *src_ = nullptr;
     dstT *dst_ = nullptr;
-    const IndexerT indexer_;
+    IndexerT indexer_;
 
 public:
     GenericCopyFunctor(const srcT *src_p, dstT *dst_p, const IndexerT &indexer)
@@ -219,7 +219,7 @@ template <typename srcT,
 class ContigCopyFunctor
 {
 private:
-    const std::size_t nelems;
+    std::size_t nelems;
     const srcT *src_p = nullptr;
     dstT *dst_p = nullptr;
 
@@ -524,9 +524,9 @@ template <typename AccessorT,
 class GenericCopyFromHostFunctor
 {
 private:
-    const AccessorT src_acc_;
+    AccessorT src_acc_;
     dstTy *dst_ = nullptr;
-    const IndexerT indexer_;
+    IndexerT indexer_;
 
 public:
     GenericCopyFromHostFunctor(const AccessorT &src_acc,
@@ -771,8 +771,8 @@ class GenericCopyForReshapeFunctor
 private:
     const Ty *src_p = nullptr;
     Ty *dst_p = nullptr;
-    const SrcIndexerT src_indexer_;
-    const DstIndexerT dst_indexer_;
+    SrcIndexerT src_indexer_;
+    DstIndexerT dst_indexer_;
 
 public:
     GenericCopyForReshapeFunctor(const char *src_ptr,
@@ -963,8 +963,8 @@ class StridedCopyForRollFunctor
 private:
     const Ty *src_p = nullptr;
     Ty *dst_p = nullptr;
-    const SrcIndexerT src_indexer_;
-    const DstIndexerT dst_indexer_;
+    SrcIndexerT src_indexer_;
+    DstIndexerT dst_indexer_;
 
 public:
     StridedCopyForRollFunctor(const Ty *src_ptr,

dpctl/tensor/libtensor/include/kernels/copy_as_contiguous.hpp

@@ -55,7 +55,7 @@ template <typename T,
 class CopyAsCContigFunctor
 {
 private:
-    const std::size_t nelems;
+    std::size_t nelems;
     const T *src_p = nullptr;
     T *dst_p = nullptr;
     IndexerT src_indexer;

dpctl/tensor/libtensor/include/kernels/elementwise_functions/common.hpp

@@ -65,7 +65,7 @@ struct UnaryContigFunctor
 private:
     const argT *in = nullptr;
     resT *out = nullptr;
-    const std::size_t nelems_;
+    std::size_t nelems_;
 
 public:
     UnaryContigFunctor(const argT *inp, resT *res, const std::size_t n_elems)
@@ -245,7 +245,7 @@ struct UnaryStridedFunctor
 private:
     const argT *inp_ = nullptr;
     resT *res_ = nullptr;
-    const IndexerT inp_out_indexer_;
+    IndexerT inp_out_indexer_;
 
 public:
     UnaryStridedFunctor(const argT *inp_p,
@@ -397,7 +397,7 @@ struct BinaryContigFunctor
     const argT1 *in1 = nullptr;
     const argT2 *in2 = nullptr;
     resT *out = nullptr;
-    const std::size_t nelems_;
+    std::size_t nelems_;
 
 public:
     BinaryContigFunctor(const argT1 *inp1,
@@ -529,7 +529,7 @@ struct BinaryStridedFunctor
     const argT1 *in1 = nullptr;
     const argT2 *in2 = nullptr;
     resT *out = nullptr;
-    const ThreeOffsets_IndexerT three_offsets_indexer_;
+    ThreeOffsets_IndexerT three_offsets_indexer_;
 
 public:
     BinaryStridedFunctor(const argT1 *inp1_tp,

dpctl/tensor/libtensor/include/kernels/elementwise_functions/common_inplace.hpp

@@ -64,7 +64,7 @@ struct BinaryInplaceContigFunctor
 private:
     const argT *rhs = nullptr;
     resT *lhs = nullptr;
-    const std::size_t nelems_;
+    std::size_t nelems_;
 
 public:
     BinaryInplaceContigFunctor(const argT *rhs_tp,
@@ -185,7 +185,7 @@ struct BinaryInplaceStridedFunctor
 private:
     const argT *rhs = nullptr;
     resT *lhs = nullptr;
-    const TwoOffsets_IndexerT two_offsets_indexer_;
+    TwoOffsets_IndexerT two_offsets_indexer_;
 
 public:
     BinaryInplaceStridedFunctor(const argT *rhs_tp,

dpctl/tensor/libtensor/include/kernels/integer_advanced_indexing.hpp

@@ -61,9 +61,9 @@ class TakeFunctor
     int k_ = 0;
     std::size_t ind_nelems_ = 0;
     const ssize_t *axes_shape_and_strides_ = nullptr;
-    const OrthogIndexer orthog_strider;
-    const IndicesIndexer ind_strider;
-    const AxesIndexer axes_strider;
+    OrthogIndexer orthog_strider;
+    IndicesIndexer ind_strider;
+    AxesIndexer axes_strider;
 
 public:
     TakeFunctor(const char *src_cp,
@@ -207,9 +207,9 @@ class PutFunctor
     int k_ = 0;
     std::size_t ind_nelems_ = 0;
     const ssize_t *axes_shape_and_strides_ = nullptr;
-    const OrthogIndexer orthog_strider;
-    const IndicesIndexer ind_strider;
-    const AxesIndexer axes_strider;
+    OrthogIndexer orthog_strider;
+    IndicesIndexer ind_strider;
+    AxesIndexer axes_strider;
 
 public:
     PutFunctor(char *dst_cp,

dpctl/tensor/libtensor/include/kernels/linalg_functions/dot_product.hpp

@@ -115,9 +115,9 @@ struct DotProductFunctor
     const lhsT *lhs_ = nullptr;
     const rhsT *rhs_ = nullptr;
     outT *out_ = nullptr;
-    const ReductionOpT reduction_op_;
-    const BatchIndexerT batch_indexer_;
-    const RedIndexerT reduced_dims_indexer_;
+    ReductionOpT reduction_op_;
+    BatchIndexerT batch_indexer_;
+    RedIndexerT reduced_dims_indexer_;
     std::size_t reduction_max_gid_ = 0;
     std::size_t batches_ = 1;
     std::size_t reductions_per_wi = 16;
@@ -211,9 +211,9 @@ struct DotProductCustomFunctor
     const lhsT *lhs_ = nullptr;
     const rhsT *rhs_ = nullptr;
     outT *out_ = nullptr;
-    const ReductionOpT reduction_op_;
-    const BatchIndexerT batch_indexer_;
-    const RedIndexerT reduced_dims_indexer_;
+    ReductionOpT reduction_op_;
+    BatchIndexerT batch_indexer_;
+    RedIndexerT reduced_dims_indexer_;
     SlmT local_mem_;
     std::size_t reduction_max_gid_ = 0;
     std::size_t batches_ = 1;
@@ -657,9 +657,9 @@ struct DotProductNoAtomicFunctor
     const lhsT *lhs_ = nullptr;
     const rhsT *rhs_ = nullptr;
     outT *out_ = nullptr;
-    const ReductionOpT reduction_op_;
-    const BatchIndexerT batch_indexer_;
-    const RedIndexerT reduced_dims_indexer_;
+    ReductionOpT reduction_op_;
+    BatchIndexerT batch_indexer_;
+    RedIndexerT reduced_dims_indexer_;
     std::size_t reduction_max_gid_ = 0;
     std::size_t batches_ = 1;
     std::size_t reductions_per_wi = 16;
@@ -756,9 +756,9 @@ struct DotProductNoAtomicCustomFunctor
     const lhsT *lhs_ = nullptr;
     const rhsT *rhs_ = nullptr;
     outT *out_ = nullptr;
-    const ReductionOpT reduction_op_;
-    const BatchIndexerT batch_indexer_;
-    const RedIndexerT reduced_dims_indexer_;
+    ReductionOpT reduction_op_;
+    BatchIndexerT batch_indexer_;
+    RedIndexerT reduced_dims_indexer_;
     SlmT local_mem_;
     std::size_t reduction_max_gid_ = 0;
     std::size_t batches_ = 1;

dpctl/tensor/libtensor/include/kernels/linalg_functions/gemm.hpp

@@ -538,10 +538,10 @@ class GemmBatchFunctorThreadK
     std::size_t n_wi = 0;
     std::size_t m = 0;
     std::size_t batch_nelems = 0;
-    const BatchDimsIndexerT batch_indexer;
-    const OuterInnerDimsIndexerT lhs_indexer;
-    const OuterInnerDimsIndexerT rhs_indexer;
-    const OuterInnerDimsIndexerT res_indexer;
+    BatchDimsIndexerT batch_indexer;
+    OuterInnerDimsIndexerT lhs_indexer;
+    OuterInnerDimsIndexerT rhs_indexer;
+    OuterInnerDimsIndexerT res_indexer;
 
 public:
     GemmBatchFunctorThreadK(const lhsT *lhs_,
@@ -907,10 +907,10 @@ class GemmBatchFunctorThreadNM_vecm
     std::uint32_t wg_delta_n = 0;
     std::uint32_t wg_delta_m = 0;
     std::uint32_t wi_delta_k = 0;
-    const BatchDimsIndexerT batch_indexer;
-    const LhsIndexerT lhs_indexer;
-    const RhsIndexerT rhs_indexer;
-    const ResIndexerT res_indexer;
+    BatchDimsIndexerT batch_indexer;
+    LhsIndexerT lhs_indexer;
+    RhsIndexerT rhs_indexer;
+    ResIndexerT res_indexer;
 
 public:
     /*! @brief */
@@ -1803,10 +1803,10 @@ class GemmBatchNoAtomicFunctorThreadNM
     std::size_t m_blocks = 0;
     std::size_t wg_delta_m = 0;
     std::size_t batch_nelems;
-    const BatchDimsIndexerT batch_indexer;
-    const OuterInnerDimsIndexerT lhs_indexer;
-    const OuterInnerDimsIndexerT rhs_indexer;
-    const ResIndexerT res_indexer;
+    BatchDimsIndexerT batch_indexer;
+    OuterInnerDimsIndexerT lhs_indexer;
+    OuterInnerDimsIndexerT rhs_indexer;
+    ResIndexerT res_indexer;
 
 public:
     GemmBatchNoAtomicFunctorThreadNM(const lhsT *lhs_,
@@ -2006,10 +2006,10 @@ class GemmBatchNoAtomicFunctorThreadK
     std::size_t n_wi = 0;
     std::size_t m = 0;
     std::size_t batch_nelems = 0;
-    const BatchDimsIndexerT batch_indexer;
-    const OuterInnerDimsIndexerT lhs_indexer;
-    const OuterInnerDimsIndexerT rhs_indexer;
-    const ResIndexerT res_indexer;
+    BatchDimsIndexerT batch_indexer;
+    OuterInnerDimsIndexerT lhs_indexer;
+    OuterInnerDimsIndexerT rhs_indexer;
+    ResIndexerT res_indexer;
 
 public:
     GemmBatchNoAtomicFunctorThreadK(const lhsT *lhs_,