[FIX] 0047121: Failed test: "Read only" für Administrationsknoten "Datei"

chfsx · chfsx · commit ff41db615999 · 2026-04-13T10:19:23.000+02:00
diff --git a/components/ILIAS/File/classes/Icons/IconListingUI.php b/components/ILIAS/File/classes/Icons/IconListingUI.php
@@ -39,11 +39,11 @@ class IconListingUI
     private Standard $icon_list;
     private \ilUIFilterService $filter_service;
     private \ILIAS\UI\Component\Input\Container\Filter\Standard $filter;
-    private \ILIAS\HTTP\Services $http;
 
     public function __construct(
         private IconRepositoryInterface $icon_repo,
-        private object $gui
+        private ilObjFileIconsOverviewGUI $gui,
+        private bool $write_access
     ) {
         global $DIC;
 
@@ -53,7 +53,6 @@ public function __construct(
         $this->ui_factory = $DIC->ui()->factory();
         $this->refinery = $DIC->refinery();
         $this->storage = $DIC->resourceStorage();
-        $this->http = $DIC->http();
         $this->filter_service = $DIC->uiService()->filter();
 
         $this->initFilter();
@@ -116,18 +115,23 @@ protected function initListing(): void
             );
             $this->deletion_modals[] = $deletion_modal = $this->getDeletionConfirmationModal($icon);
 
-            $item_action_entries = [
-                $this->ui_factory->button()->shy(
-                    $this->lng->txt('de_activate_icon'),
-                    $change_activation_target
-                )
-            ];
-            if (!$icon->isDefaultIcon()) {
-                $item_action_entries[] = $this->ui_factory->button()->shy($this->lng->txt('edit'), $edit_target);
-                $item_action_entries[] = $this->ui_factory->button()->shy($this->lng->txt('delete'), '#')->withOnClick(
-                    $deletion_modal->getShowSignal()
-                );
+            if ($this->write_access) {
+                $item_action_entries = [
+                    $this->ui_factory->button()->shy(
+                        $this->lng->txt('de_activate_icon'),
+                        $change_activation_target
+                    )
+                ];
+                if (!$icon->isDefaultIcon()) {
+                    $item_action_entries[] = $this->ui_factory->button()->shy($this->lng->txt('edit'), $edit_target);
+                    $item_action_entries[] = $this->ui_factory->button()->shy($this->lng->txt('delete'), '#')->withOnClick(
+                        $deletion_modal->getShowSignal()
+                    );
+                }
+            } else {
+                $item_action_entries = [];
             }
+
             $item_actions = $this->ui_factory->dropdown()->standard($item_action_entries);
 
             $id = $this->storage->manage()->find($icon->getRid());
diff --git a/components/ILIAS/File/classes/Icons/class.ilObjFileIconsOverviewGUI.php b/components/ILIAS/File/classes/Icons/class.ilObjFileIconsOverviewGUI.php
@@ -54,11 +54,14 @@ class ilObjFileIconsOverviewGUI
     private Services $storage;
     private IconRepositoryInterface $icon_repo;
     private \ilFileServicesSettings $file_service_settings;
+    private \ilAccessHandler $access;
+    private bool $write_access;
 
     final public function __construct()
     {
         global $DIC;
         $this->ctrl = $DIC->ctrl();
+        $this->access = $DIC->access();
         $this->lng = $DIC->language();
         $this->lng->loadLanguageModule('file');
         $this->toolbar = $DIC->toolbar();
@@ -71,6 +74,11 @@ final public function __construct()
         $this->storage = $DIC->resourceStorage();
         $this->icon_repo = new IconDatabaseRepository();
         $this->file_service_settings = $DIC->fileServiceSettings();
+        $this->write_access = $this->access->checkAccess(
+            'write',
+            '',
+            (int) ($this->http_request->getQueryParams()['ref_id'] ?? 0)
+        );
     }
 
     final public function executeCommand(): void
@@ -95,16 +103,19 @@ final public function executeCommand(): void
     private function index(): void
     {
         // toolbar: add new icon button
-        $btn_new_icon = $this->ui_factory->button()->standard(
-            $this->lng->txt('add_icon'),
-            $this->ctrl->getLinkTargetByClass(self::class, self::CMD_OPEN_CREATION_FORM)
-        );
-        $this->toolbar->addComponent($btn_new_icon);
+        if ($this->write_access) {
+            $btn_new_icon = $this->ui_factory->button()->standard(
+                $this->lng->txt('add_icon'),
+                $this->ctrl->getLinkTargetByClass(self::class, self::CMD_OPEN_CREATION_FORM)
+            );
+            $this->toolbar->addComponent($btn_new_icon);
+        }
 
         // Listing of icons
         $listing = new IconListingUI(
             $this->icon_repo,
-            $this
+            $this,
+            $this->write_access
         );
 
         $content = [];
diff --git a/components/ILIAS/File/classes/Preview/Form.php b/components/ILIAS/File/classes/Preview/Form.php
@@ -1,21 +1,5 @@
 <?php
 
-/**
- * This file is part of ILIAS, a powerful learning management system
- * published by ILIAS open source e-Learning e.V.
- *
- * ILIAS is licensed with the GPL-3.0,
- * see https://www.gnu.org/licenses/gpl-3.0.en.html
- * You should have received a copy of said license along with the
- * source code, too.
- *
- * If this is not the case or you just want to try ILIAS, you'll find
- * us at:
- * https://www.ilias.de
- * https://github.com/ILIAS-eLearning
- *
- *********************************************************************/
-
 namespace ILIAS\components\File\Preview;
 
 use ILIAS\UI\Component\Input\Field\Factory;
@@ -31,8 +15,10 @@ class Form
     private Factory $field_factory;
     private \ILIAS\Refinery\Factory $refinery;
 
-    public function __construct(private Settings $settings)
-    {
+    public function __construct(
+        private Settings $settings,
+        private bool $write_access
+    ) {
         global $DIC;
         $this->language = $DIC->language();
         $this->field_factory = $DIC->ui()->factory()->input()->field();
@@ -56,10 +42,10 @@ public function asFormGroup(): Group
                 $this->language->txt('enable_preview'),
                 $this->language->txt('enable_preview_info')
             )
-            ->withDisabled(!$possible)
+            ->withDisabled(!$this->write_access || !$possible)
             ->withValue($this->settings->isPreviewEnabled())
             ->withAdditionalTransformation(
-                $this->refinery->custom()->transformation(function ($v): void {
+                $this->refinery->custom()->transformation(function (bool $v): void {
                     $this->settings->setPreviewEnabled($v);
                 })
             );
@@ -69,11 +55,11 @@ public function asFormGroup(): Group
                 $this->language->txt('preview_image_size'),
                 $this->language->txt('preview_image_size_info')
             )
-            ->withDisabled(!$possible)
+            ->withDisabled(!$this->write_access || !$possible)
             ->withRequired(true)
             ->withValue($this->settings->getImageSize())
             ->withAdditionalTransformation(
-                $this->refinery->custom()->transformation(function ($v): void {
+                $this->refinery->custom()->transformation(function (int $v): void {
                     $this->settings->setImageSize($v);
                 })
             );
@@ -83,10 +69,10 @@ public function asFormGroup(): Group
                 $this->language->txt('preview_persisting'),
                 $this->language->txt('preview_persisting_info')
             )
-            ->withDisabled(!$possible)
+            ->withDisabled(!$this->write_access || !$possible)
             ->withValue($this->settings->isPersisting())
             ->withAdditionalTransformation(
-                $this->refinery->custom()->transformation(function ($v): void {
+                $this->refinery->custom()->transformation(function (bool $v): void {
                     $this->settings->setPersisting($v);
                 })
             );
@@ -96,10 +82,10 @@ public function asFormGroup(): Group
                 $this->language->txt('max_previews_per_object'),
                 $this->language->txt('max_previews_per_object_info')
             )
-            ->withDisabled(!$possible)
+            ->withDisabled(!$this->write_access || !$possible)
             ->withValue($this->settings->getMaximumPreviews())
             ->withAdditionalTransformation(
-                $this->refinery->custom()->transformation(function ($v): void {
+                $this->refinery->custom()->transformation(function (int $v): void {
                     $this->settings->setMaximumPreviews($v);
                 })
             );
@@ -109,10 +95,10 @@ public function asFormGroup(): Group
                 $this->language->txt('previews_for_tiles'),
                 $this->language->txt('previews_for_tiles_info')
             )
-            ->withDisabled(!$possible)
+            ->withDisabled(!$this->write_access || !$possible)
             ->withValue($this->settings->hasTilePreviews())
             ->withAdditionalTransformation(
-                $this->refinery->custom()->transformation(function ($v): void {
+                $this->refinery->custom()->transformation(function (bool $v): void {
                     $this->settings->setTilePreviews($v);
                 })
             );
diff --git a/components/ILIAS/File/classes/Settings/Form.php b/components/ILIAS/File/classes/Settings/Form.php
@@ -1,21 +1,5 @@
 <?php
 
-/**
- * This file is part of ILIAS, a powerful learning management system
- * published by ILIAS open source e-Learning e.V.
- *
- * ILIAS is licensed with the GPL-3.0,
- * see https://www.gnu.org/licenses/gpl-3.0.en.html
- * You should have received a copy of said license along with the
- * source code, too.
- *
- * If this is not the case or you just want to try ILIAS, you'll find
- * us at:
- * https://www.ilias.de
- * https://github.com/ILIAS-eLearning
- *
- *********************************************************************/
-
 namespace ILIAS\components\File\Settings;
 
 use ILIAS\UI\Component\Input\Field\Factory;
@@ -31,8 +15,10 @@ class Form
     private Factory $field_factory;
     private \ILIAS\Refinery\Factory $refinery;
 
-    public function __construct(private General $settings)
-    {
+    public function __construct(
+        private General $settings,
+        private bool $write_access
+    ) {
         global $DIC;
         $this->language = $DIC->language();
         $this->language->loadLanguageModule("bgtask");
@@ -57,8 +43,9 @@ public function asFormGroup(): Group
             )
             ->withValue($this->settings->getDownloadLimitinMB())
             ->withRequired(true)
+            ->withDisabled(!$this->write_access)
             ->withAdditionalTransformation(
-                $this->refinery->custom()->transformation(function ($value) {
+                $this->refinery->custom()->transformation(function (int $value): int {
                     $this->settings->setDownloadLimitInMB($value);
                     return $value;
                 })
@@ -71,8 +58,9 @@ public function asFormGroup(): Group
                 $this->language->txt('inline_file_extensions_info')
             )
             ->withValue($this->settings->getInlineFileExtensions())
+            ->withDisabled(!$this->write_access)
             ->withAdditionalTransformation(
-                $this->refinery->custom()->transformation(function ($value) {
+                $this->refinery->custom()->transformation(function (array $value): array {
                     $this->settings->setInlineFileExtensions($value);
                     return $value;
                 })
@@ -84,9 +72,10 @@ public function asFormGroup(): Group
                 $this->language->txt('show_amount_of_downloads_info')
             )
             ->withValue($this->settings->isShowAmountOfDownloads())
+            ->withDisabled(!$this->write_access)
             ->withAdditionalTransformation(
                 $this->refinery->custom()->transformation(
-                    function ($value) {
+                    function (bool $value): bool {
                         $this->settings->setShowAmountOfDownloads($value);
                         return $value;
                     }
@@ -99,8 +88,9 @@ function ($value) {
                 $this->language->txt('download_ascii_filename_info')
             )
             ->withValue($this->settings->isDownloadWithAsciiFileName())
+            ->withDisabled(!$this->write_access)
             ->withAdditionalTransformation(
-                $this->refinery->custom()->transformation(function ($value) {
+                $this->refinery->custom()->transformation(function (bool $value): bool {
                     $this->settings->setDownloadWithAsciiFileName($value);
                     return $value;
                 })
diff --git a/components/ILIAS/File/classes/class.ilObjFileAccessSettingsGUI.php b/components/ILIAS/File/classes/class.ilObjFileAccessSettingsGUI.php
@@ -20,7 +20,6 @@
 use ILIAS\UI\Factory;
 use ILIAS\UI\Renderer;
 use ILIAS\UI\Component\Input\Container\Form\Standard;
-use ILIAS\HTTP\Services;
 use ILIAS\File\Icon\ilObjFileIconsOverviewGUI;
 use ILIAS\components\File\Preview\Settings;
 use ILIAS\components\File\Settings\General;
@@ -47,6 +46,7 @@ class ilObjFileAccessSettingsGUI extends ilObjectGUI
     private ilLanguage $language;
     private Form $preview_settings;
     private \ILIAS\components\File\Settings\Form $file_object_settings;
+    private bool $write_access;
     protected Factory $ui_factory;
     protected Renderer $ui_renderer;
 
@@ -60,8 +60,15 @@ public function __construct($a_data, int $a_id, bool $a_call_by_reference)
         global $DIC;
         $this->type = "facs";
         parent::__construct($a_data, $a_id, $a_call_by_reference, false);
-        $this->preview_settings = new Form(new Settings());
-        $this->file_object_settings = new \ILIAS\components\File\Settings\Form(new General());
+        $this->write_access = $this->access->checkAccess('write', '', $this->object->getRefId());
+        $this->preview_settings = new Form(
+            new Settings(),
+            $this->write_access
+        );
+        $this->file_object_settings = new \ILIAS\components\File\Settings\Form(
+            new General(),
+            $this->write_access
+        );
         $this->ui_factory = $DIC->ui()->factory();
         $this->ui_renderer = $DIC->ui()->renderer();
         $this->language = $DIC->language();
@@ -169,7 +176,6 @@ protected function editSettings(): void
     {
         $this->addFileObjectsSubTabs();
         $this->tabs_gui->setSubTabActive("settings");
-        $form = $this->buildForm();
         $this->tpl->setContent($this->ui_renderer->render($this->buildForm()));
     }
 
