Cron: minor adjustments

Author: nhaagen

components/ILIAS/Cron/classes/Setup/class.ilCronJobSetupAgent.php

@@ -24,7 +24,7 @@
 class ilCronJobSetupAgent implements Setup\Agent
 {
     public function __construct(
-        private array $cronjobs
+        private readonly array $cronjobs
     ) {
     }
 

components/ILIAS/Cron/classes/Setup/class.ilCronJobsRegisteredObjective.php

@@ -23,37 +23,25 @@
 class ilCronjobsRegisteredObjective implements Setup\Objective
 {
     public function __construct(
-        private array $cronjobs
+        private readonly array $cronjobs
     ) {
     }
 
-    /**
-     * @inheritdoc
-     */
     public function getHash(): string
     {
         return hash("sha256", self::class);
     }
 
-    /**
-     * @inheritdoc
-     */
     public function getLabel(): string
     {
         return "CronJobs are registered.";
     }
 
-    /**
-     * @inheritdoc
-     */
     public function isNotable(): bool
     {
         return true;
     }
 
-    /**
-     * @inheritdoc
-     */
     public function getPreconditions(Setup\Environment $environment): array
     {
         return [
@@ -63,9 +51,6 @@ public function getPreconditions(Setup\Environment $environment): array
         ];
     }
 
-    /**
-     * @inheritdoc
-     */
     public function achieve(Setup\Environment $environment): Setup\Environment
     {
         $db = $environment->getResource(Setup\Environment::RESOURCE_DATABASE);
@@ -107,9 +92,6 @@ public function achieve(Setup\Environment $environment): Setup\Environment
         return $environment;
     }
 
-    /**
-     * @inheritdoc
-     */
     public function isApplicable(Setup\Environment $environment): bool
     {
         return true;

components/ILIAS/Cron/classes/class.ilCronJobRepositoryImpl.php

@@ -123,7 +123,7 @@ public function registerJob(
 
     public function unregisterAllJobs(): void
     {
-        $query = 'TRUNCATE cron_job;';
+        $query = 'DELETE FROM cron_job';
         $res = $this->db->manipulate($query);
     }
 

components/ILIAS/Cron/interfaces/interface.ilCronJobRepository.php

@@ -41,6 +41,8 @@ public function registerJob(string $a_component, string $a_id, string $a_class,
 
     public function unregisterJob(string $a_component, array $a_xml_job_ids): void;
 
+    public function unregisterAllJobs(): void;
+
     public function createDefaultEntry(ilCronJob $job, string $component, string $class, ?string $path): void;
 
     /**
@@ -67,4 +69,5 @@ public function activateJob(ilCronJob $job, DateTimeImmutable $when, ilObjUser $
     public function deactivateJob(ilCronJob $job, DateTimeImmutable $when, ilObjUser $actor, bool $wasManuallyExecuted = false): void;
 
     public function findAll(): ilCronJobCollection;
+
 }

components/ILIAS/Cron/src/CronRegistry.php

@@ -26,7 +26,7 @@ class CronRegistry implements Registry
      * @param ilCronJob[] $jobs
      */
     public function __construct(
-        private array $jobs
+        private readonly array $jobs
     ) {
     }