Component/Test: contribute cron jobs

Author: nhaagen

components/ILIAS/Test/Test.php

@@ -48,5 +48,11 @@ public function init(
             new Component\Resource\ComponentCSS($this, "test_print.css");
         $contribute[Component\Resource\PublicAsset::class] = fn() =>
             new Component\Resource\ComponentCSS($this, "test_print_hide_content.css");
+        $contribute[\ILIAS\Cron\CronJob::class] = static fn() =>
+            new \ilCronFinishUnfinishedTestPasses(
+                self::class,
+                $use[\ILIAS\Language\Language::class],
+                $use[\ILIAS\Logging\LoggerFactory::class]
+            );
     }
 }

components/ILIAS/Test/classes/class.ilCronFinishUnfinishedTestPasses.php

@@ -30,28 +30,26 @@
  */
 class ilCronFinishUnfinishedTestPasses extends ilCronJob
 {
-    protected readonly TestLogger $logger;
-
-    protected readonly ilLanguage $lng;
-    protected readonly ilDBInterface $db;
-    protected readonly ilObjUser $user;
-    protected readonly ilObjectDataCache $obj_data_cache;
+    protected TestLogger $logger;
+    protected ilDBInterface $db;
+    protected ilObjUser $user;
+    protected ilObjectDataCache $obj_data_cache;
     protected int $now;
     protected array $unfinished_passes;
     protected array $test_ids;
     protected array $test_ending_times;
     protected ilTestProcessLockerFactory $processLockerFactory;
     protected TestResultRepository $test_pass_result_repository;
 
-    public function __construct()
+    public function init(): void
     {
+        $this->lng->loadLanguageModule('assessment');
+
         /** @var ILIAS\DI\Container $DIC */
         global $DIC;
 
         $this->logger = TestDIC::dic()['logging.logger'];
-        $this->lng = $DIC['lng'];
         $this->user = $DIC['ilUser'];
-        $this->lng->loadLanguageModule('assessment');
         $this->db = $DIC->database();
         $this->obj_data_cache = $DIC['ilObjDataCache'];
         $this->now = time();

components/ILIAS/Test/module.xml

@@ -30,9 +30,6 @@
 			<parent id="wfld">wfld</parent>
 		</object>
 	</objects>
-	<crons>
-		<cron id="finish_unfinished_passes" class="ilCronFinishUnfinishedTestPasses" />
-	</crons>
 	<pluginslots>
 		<pluginslot id="texp" name="Export" />
 	</pluginslots>

components/ILIAS/Test/tests/ilCronFinishUnfinishedTestPassesTest.php

@@ -19,6 +19,7 @@
 declare(strict_types=1);
 
 use ILIAS\Cron\Schedule\CronJobScheduleType;
+use ILIAS\Logging\LoggerFactory;
 
 /**
  * Class ilCronFinishUnfinishedTestPassesTest
@@ -40,7 +41,15 @@ protected function setUp(): void
             define("ILIAS_LOG_ENABLED", false);
         }
 
-        $this->test_obj = new ilCronFinishUnfinishedTestPasses();
+        $logger_factory = $this->getMockBuilder(LoggerFactory::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $this->test_obj = new ilCronFinishUnfinishedTestPasses(
+            'components\ILIAS\Test',
+            $GLOBALS['lng'],
+            $logger_factory
+        );
     }
 
     public function test_instantiateObject_shouldReturnInstance(): void
@@ -63,8 +72,16 @@ public function testGetTitle(): void
             ->willReturn('testString')
         ;
 
+        $logger_factory = $this->getMockBuilder(LoggerFactory::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
         $this->setGlobalVariable('lng', $lng_mock);
-        $test_obj = new ilCronFinishUnfinishedTestPasses();
+        $test_obj = new ilCronFinishUnfinishedTestPasses(
+            'components\ILIAS\Test',
+            $GLOBALS['lng'],
+            $logger_factory
+        );
 
         $this->assertEquals('testString', $test_obj->getTitle());
     }
@@ -79,8 +96,16 @@ public function testGetDescription(): void
             ->willReturn('testString')
         ;
 
+        $logger_factory = $this->getMockBuilder(LoggerFactory::class)
+            ->disableOriginalConstructor()
+            ->getMock();
+
         $this->setGlobalVariable('lng', $lng_mock);
-        $test_obj = new ilCronFinishUnfinishedTestPasses();
+        $test_obj = new ilCronFinishUnfinishedTestPasses(
+            'components\ILIAS\Test',
+            $GLOBALS['lng'],
+            $logger_factory
+        );
 
         $this->assertEquals('testString', $test_obj->getDescription());
     }