Component/Membership: contribute cron jobs

Author: nhaagen

components/ILIAS/Membership/Membership.php

@@ -32,6 +32,17 @@ public function init(
         array | \ArrayAccess &$pull,
         array | \ArrayAccess &$internal,
     ): void {
-        // ...
+        $contribute[\ILIAS\Cron\CronJob::class] = static fn() =>
+            new \ilMembershipCronMinMembers(
+                'components\\' . self::class,
+                $use[\ILIAS\Language\Language::class]
+            );
+        $contribute[\ILIAS\Cron\CronJob::class] = static fn() =>
+            new \ilMembershipCronNotifications(
+                'components\\' . self::class,
+                $use[\ILIAS\Language\Language::class],
+                true
+            );
+
     }
 }

components/ILIAS/Membership/classes/Cron/class.ilMembershipCronMinMembers.php

@@ -1,9 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
-
-
 /**
  * This file is part of ILIAS, a powerful learning management system
  * published by ILIAS open source e-Learning e.V.
@@ -20,6 +16,8 @@
  *
  *********************************************************************/
 
+declare(strict_types=1);
+
 use ILIAS\Cron\Schedule\CronJobScheduleType;
 
 /**
@@ -29,15 +27,6 @@
  */
 class ilMembershipCronMinMembers extends ilCronJob
 {
-    protected ilLanguage $lng;
-
-    public function __construct()
-    {
-        global $DIC;
-
-        $this->lng = $DIC->language();
-    }
-
     public function getId(): string
     {
         return "mem_min_members";

components/ILIAS/Membership/classes/Cron/class.ilMembershipCronNotifications.php

@@ -1,9 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
-
-
 /**
  * This file is part of ILIAS, a powerful learning management system
  * published by ILIAS open source e-Learning e.V.
@@ -20,6 +16,8 @@
  *
  *********************************************************************/
 
+declare(strict_types=1);
+
 use ILIAS\Cron\Schedule\CronJobScheduleType;
 
 /**
@@ -28,16 +26,24 @@
  */
 class ilMembershipCronNotifications extends ilCronJob
 {
-    protected ilLanguage $lng;
     protected ilDBInterface $db;
     protected ilLogger $logger;
     protected ilTree $tree;
 
-    public function __construct()
+    public function __construct(
+        string $component,
+        \ILIAS\Language\Language $lng,
+        bool $registration = false
+    ) {
+        parent::__construct($component, $lng);
+        if (!$registration) {
+            $this->additionalConstruct();
+        }
+    }
+
+    private function additionalConstruct()
     {
         global $DIC;
-
-        $this->lng = $DIC->language();
         $this->db = $DIC->database();
         $this->logger = $DIC->logger()->mmbr();
         $this->tree = $DIC->repositoryTree();

components/ILIAS/Membership/classes/Cron/class.ilMembershipCronNotificationsData.php

@@ -1,9 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
-
-
 /**
  * This file is part of ILIAS, a powerful learning management system
  * published by ILIAS open source e-Learning e.V.
@@ -20,6 +16,8 @@
  *
  *********************************************************************/
 
+declare(strict_types=1);
+
 use ILIAS\Notes\Service;
 
 /**

components/ILIAS/Membership/service.xml

@@ -3,9 +3,5 @@
 	<baseclasses>
 		<baseclass name="ilMembershipOverviewGUI" dir="classes" />
 	</baseclasses>
-	<crons>
-		<cron id="mem_notification" class="ilMembershipCronNotifications" path="Services/Membership/classes/Cron" />
-		<cron id="mem_min_members" class="ilMembershipCronMinMembers" path="Services/Membership/classes/Cron" />
-	</crons>
 	<logging />
 </service>