[FIX] #47059 UI: remove MainControls\Slate\Legacy aria-role attribute. (#11014)

* Fixes https://mantis.ilias.de/view.php?id=47059
* Removes the `aria-role` attribute because we cannot safely tell what content is held by a legacy slate. Its content is of type `Component\Legacy` which holds arbitrary HTML.

Author: fhelfer

components/ILIAS/UI/src/Implementation/Component/MainControls/Renderer.php

@@ -24,6 +24,7 @@
 use ILIAS\UI\Component\MainControls\Footer;
 use ILIAS\UI\Component\MainControls\MainBar;
 use ILIAS\UI\Component\MainControls\MetaBar;
+use ILIAS\UI\Component\MainControls\Slate\Legacy as LegacySlate;
 use ILIAS\UI\Component\MainControls\Slate\Slate;
 use ILIAS\UI\Component\Signal;
 use ILIAS\UI\Implementation\Component\Button\Bulky as IBulky;
@@ -166,7 +167,9 @@ function ($id) use ($js, $mb_id, $k, $is_tool): string {
             $tpl->parseCurrentBlock();
 
             if ($slate) {
-                $entry = $entry->withAriaRole(ISlate::MENU);
+                if (!$entry instanceof LegacySlate) {
+                    $entry = $entry->withAriaRole(ISlate::MENU);
+                }
 
                 $tpl->setCurrentBlock("slate_item");
                 $tpl->setVariable("SLATE", $default_renderer->render($entry));

components/ILIAS/UI/tests/Component/MainControls/MainBarTest.php

@@ -324,7 +324,7 @@ public function testRendering(): void
                 <div class="il-maincontrols-slate disengaged" id="id_10" data-depth-level="1" role="menu">
                   <div class="il-maincontrols-slate-content" data-replace-marker="content"></div>
                 </div>
-                <div class="il-maincontrols-slate disengaged" id="id_13" data-depth-level="1" role="menu">
+                <div class="il-maincontrols-slate disengaged" id="id_13" data-depth-level="1">
                   <div class="il-maincontrols-slate-content" data-replace-marker="content">Help</div>
                 </div>
                 <div class="il-mainbar-close-slates">