Object: Improve Presentation of Creation Form

See: https://mantis.ilias.de/view.php?id=43244

Author: kergomard

components/ILIAS/ILIASObject/classes/class.ilObject.php

@@ -1846,19 +1846,17 @@ public static function getIconForReference(
         bool $offline = false
     ): string {
         global $DIC;
-
         $ilSetting = $DIC->settings();
-        $objDefinition = $DIC["objDefinition"];
 
         if ($obj_id == "" && $type == "") {
             return "";
         }
 
-        if ($type == "") {
+        if ($type === "") {
             $type = ilObject::_lookupType($obj_id);
         }
 
-        if ($size == "") {
+        if ($size === "") {
             $size = "big";
         }
 
@@ -1884,21 +1882,27 @@ public static function getIconForReference(
         }
 
         if (!$offline) {
-            if ($objDefinition->isPluginTypeName($type)) {
-                if ($objDefinition->getClassName($type) != "") {
-                    $class_name = "il" . $objDefinition->getClassName($type) . 'Plugin';
-                    $location = $objDefinition->getLocation($type);
-                    if (is_file($location . "/class." . $class_name . ".php")) {
-                        return call_user_func([$class_name, "_getIcon"], $type, $size, $obj_id);
-                    }
-                }
-                return ilUtil::getImagePath("standard/icon_cmps.svg");
-            }
+            return self::getIconForType($type);
+        }
+        return "./images/standard/icon_{$type}.svg";
+    }
 
-            return ilUtil::getImagePath("standard/icon_" . $type . ".svg");
-        } else {
-            return "./images/standard/icon_" . $type . ".svg";
+    public static function getIconForType(string $type): string
+    {
+        global $DIC;
+        $objDefinition = $DIC['objDefinition'];
+        if (!$objDefinition->isPluginTypeName($type)) {
+            return ilUtil::getImagePath("standard/icon_{$type}.svg");
+        }
+
+        if ($objDefinition->getClassName($type) !== '') {
+            $class_name = "il{$objDefinition->getClassName($type)}Plugin";
+            $location = $objDefinition->getLocation($type);
+            if (is_file($location . "/class.{$class_name}.php")) {
+                return call_user_func([$class_name, '_getIcon'], $type);
+            }
         }
+        return ilUtil::getImagePath('standard/icon_cmps.svg');
     }
 
     /**

components/ILIAS/ILIASObject/classes/class.ilObjectGUI.php

@@ -648,7 +648,10 @@ public function createObject(): void
         $this->lng->loadLanguageModule($new_type);
         $this->ctrl->setParameter($this, 'new_type', $new_type);
 
+        $this->tpl->setTitleIcon(ilObject::getIconForType($this->requested_new_type));
+        $this->tpl->setTitle($this->lng->txt('obj_' . $this->requested_new_type));
         $create_form = $this->initCreateForm($new_type);
+        $this->tabs_gui->setBackTarget($this->lng->txt('cancel'), $this->ctrl->getLinkTargetByClass(static::class, 'cancel'));
         $this->tpl->setContent($this->getCreationFormsHTML($create_form));
     }