Component/Skill: contribute cron jobs

Author: nhaagen

components/ILIAS/Skill/Skill.php

@@ -38,5 +38,12 @@ public function init(
             );
         $contribute[Component\Resource\PublicAsset::class] = fn() =>
             new Component\Resource\ComponentJS($this, "SkillEntries.js");
+
+        $contribute[\ILIAS\Cron\CronJob::class] = static fn() =>
+            new \ilSkillNotifications(
+                self::class,
+                $use[\ILIAS\Language\Language::class],
+                $use[\ILIAS\Logging\LoggerFactory::class]
+            );
     }
 }

components/ILIAS/Skill/classes/class.ilSkillNotifications.php

@@ -1,7 +1,5 @@
 <?php
 
-declare(strict_types=1);
-
 /**
  * This file is part of ILIAS, a powerful learning management system
  * published by ILIAS open source e-Learning e.V.
@@ -16,8 +14,9 @@
  * https://www.ilias.de
  * https://github.com/ILIAS-eLearning
  *
- ********************************************************************
- */
+ *********************************************************************/
+
+declare(strict_types=1);
 
 use ILIAS\Skill\Service\SkillTreeService;
 use ILIAS\Cron\Schedule\CronJobScheduleType;
@@ -29,17 +28,17 @@
  */
 class ilSkillNotifications extends ilCronJob
 {
-    protected ilLanguage $lng;
     protected ilObjUser $user;
     protected ilIniFile $client_ini;
     protected ilTree $tree;
     protected SkillTreeService $tree_service;
 
-    public function __construct()
+    public function init(): void
     {
+        $this->lng->loadLanguageModule("skll");
+
         global $DIC;
 
-        $this->lng = $DIC->language();
         if (isset($DIC["ilUser"])) {
             $this->user = $DIC->user();
         }
@@ -59,16 +58,12 @@ public function getId(): string
 
     public function getTitle(): string
     {
-        $lng = $this->lng;
-        $lng->loadLanguageModule("skll");
-        return $lng->txt("skll_skill_notification");
+        return $this->lng->txt("skll_skill_notification");
     }
 
     public function getDescription(): string
     {
-        $lng = $this->lng;
-        $lng->loadLanguageModule("skll");
-        return $lng->txt("skll_skill_notification_desc");
+        return $this->lng->txt("skll_skill_notification_desc");
     }
 
     public function getDefaultScheduleType(): CronJobScheduleType

components/ILIAS/Skill/service.xml

@@ -19,7 +19,4 @@
 		<event type="listen" id="components/ILIAS/Object" />
 		<event type="raise" id="deleteSkill" />
 	</events>
-	<crons>
-		<cron id="skll_notification" class="ilSkillNotifications" />
-	</crons>
 </service>