[FIX] Remove setAccessible(true) "Reflection API" calls from codebase

Author: mjansenDatabay

components/ILIAS/AdvancedMetaData/tests/record/ilAdvancedMDRecordObjectOrderingsTest.php

@@ -38,7 +38,6 @@ public function testConstruct(): void
     public function testGlobalRecordSorting(): void
     {
         $record_id_reflection = new ReflectionMethod(ilAdvancedMDRecord::class, 'setRecordId');
-        $record_id_reflection->setAccessible(true);
 
         $ids = [1, 2, 3, 4, 5];
         $positions = array_reverse($ids);

components/ILIAS/Chatroom/tests/ilObjChatroomAccessTest.php

@@ -211,7 +211,6 @@ protected function setUp(): void
 
         $settingsReflection = new ReflectionClass(ilSetting::class);
         $cache = $settingsReflection->getProperty('settings_cache');
-        $cache->setAccessible(true);
         $cache->setValue($settingsReflection, []);
 
         $this->access = new ilObjChatroomAccess();

components/ILIAS/File/classes/Versions/class.ilObjFileVersion.php

@@ -41,7 +41,6 @@ public function getArrayCopy(): array
         $a = [];
         $r = new ReflectionClass($this);
         foreach ($r->getProperties() as $p) {
-            $p->setAccessible(true);
             $a[$p->getName()] = $p->getValue($this);
         }
         return $a;

components/ILIAS/File/tests/ilModulesFileTest.php

@@ -138,7 +138,6 @@ public function testAppendStream(): void
 
         $r = new ReflectionClass(ilObjFile::class);
         $property = $r->getProperty('just_notified');
-        $property->setAccessible(true);
         $property->setValue($file, true);
         $file->setMode(ilObjFile::MODE_FILELIST);
         $this->db_mock

components/ILIAS/Mail/tests/ilMailAddressTypesTest.php

@@ -59,7 +59,6 @@ private function getWrappedAddressType(ilMailAddressType $type): ilMailAddressTy
         if ($type instanceof ilMailCachedAddressType) {
             $refl = new ReflectionObject($type);
             $inner = $refl->getProperty('inner');
-            $inner->setAccessible(true);
 
             return $inner->getValue($type);
         }

components/ILIAS/Test/tests/ilTestSkillLevelThresholdImportListTest.php

@@ -46,7 +46,6 @@ public function testAddOriginalSkillTitle(): void
         $this->testObj->addOriginalSkillTitle($skillBaseId, $skillTrefId, $originalSkillTitle);
 
         $reflProp = new ReflectionProperty($this->testObj, 'originalSkillTitles');
-        $reflProp->setAccessible(true);
 
         $this->assertEquals(["$skillBaseId:$skillTrefId" => $originalSkillTitle], $reflProp->getValue($this->testObj));
     }
@@ -59,7 +58,6 @@ public function testAddOriginalSkillPath(): void
         $this->testObj->addOriginalSkillPath($skillBaseId, $skillTrefId, $originalSkillPath);
 
         $reflProp = new ReflectionProperty($this->testObj, 'originalSkillPaths');
-        $reflProp->setAccessible(true);
 
         $this->assertEquals(["$skillBaseId:$skillTrefId" => $originalSkillPath], $reflProp->getValue($this->testObj));
     }
@@ -70,7 +68,6 @@ public function testAddSkillLevelThreshold(): void
         $this->testObj->addSkillLevelThreshold($testSkillLevelThresholdImport);
 
         $reflProp = new ReflectionProperty($this->testObj, 'importedSkillLevelThresholds');
-        $reflProp->setAccessible(true);
 
         $this->assertEquals([$testSkillLevelThresholdImport], $reflProp->getValue($this->testObj));
     }

components/ILIAS/TestQuestionPool/tests/assLongMenuTest.php

@@ -32,7 +32,6 @@ protected static function getMethod($name): ReflectionMethod
     {
         $class = new ReflectionClass(assLongMenu::class);
         $method = $class->getMethod($name);
-        $method->setAccessible(true);
         return $method;
     }
 

components/ILIAS/Tree/tests/ilRepositoryTreeTest.php

@@ -55,7 +55,6 @@ public function testInitLanguage(): void
         $tree = new ilTree(1);
         $tree->initLangCode();
         $tree_reflection = new ReflectionProperty($tree, 'lang_code');
-        $tree_reflection->setAccessible(true);
         $this->assertEquals('en', $tree_reflection->getValue($tree));
 
         // user getCurrentLanguage() from session is empty
@@ -69,7 +68,6 @@ public function testInitLanguage(): void
         $this->setGlobalVariable('ilUser', $user);
         $tree->initLangCode();
         $tree_reflection = new ReflectionProperty($tree, 'lang_code');
-        $tree_reflection->setAccessible(true);
         $this->assertEquals('en', $tree_reflection->getValue($tree));
     }