Cron: make CronRegistry a proper service

Author: klees

components/ILIAS/Cron/Cron.php

@@ -34,12 +34,12 @@ public function init(
     ): void {
         $contribute[\ILIAS\Setup\Agent::class] = static fn() =>
             new \ilCronJobSetupAgent(
-                $seek[\ILIAS\Cron\CronJob::class]
+                $use[\ILIAS\Cron\Registry::class]
             );
 
         $define[] = Cron\Registry::class;
 
-        $provide[Cron\Registry::class] = static fn() =>
+        $implement[Cron\Registry::class] = static fn() =>
             $internal[Cron\CronRegistry::class];
 
         $internal[Cron\CronRegistry::class] = static fn() =>

components/ILIAS/Cron/classes/Setup/class.ilCronJobSetupAgent.php

@@ -24,7 +24,7 @@
 class ilCronJobSetupAgent implements Setup\Agent
 {
     public function __construct(
-        private array $cronjobs
+        private \ILIAS\Cron\Registry $registry
     ) {
     }
 
@@ -41,14 +41,14 @@ public function getArrayToConfigTransformation(): Refinery\Transformation
     public function getInstallObjective(Setup\Config $config = null): Setup\Objective
     {
         return new ilCronjobsRegisteredObjective(
-            $this->cronjobs
+            $this->registry
         );
     }
 
     public function getUpdateObjective(Setup\Config $config = null): Setup\Objective
     {
         return new ilCronjobsRegisteredObjective(
-            $this->cronjobs
+            $this->registry
         );
     }
 

components/ILIAS/Cron/classes/Setup/class.ilCronJobsRegisteredObjective.php

@@ -23,7 +23,7 @@
 class ilCronjobsRegisteredObjective implements Setup\Objective
 {
     public function __construct(
-        private array $cronjobs
+        private \ILIAS\Cron\Registry $registry
     ) {
     }
 
@@ -79,11 +79,10 @@ public function achieve(Setup\Environment $environment): Setup\Environment
         $mock_logger_factory = new class () implements \ILIAS\Logging\LoggerFactory {
         };
 
-        $registry = new ILIAS\Cron\CronRegistry($this->cronjobs);
         $language = new ilSetupLanguage('en');
 
         $repo = new ilCronJobRepositoryImpl(
-            $registry,
+            $this->registry,
             $db,
             $settings_factory->settingsFor(),
             new ILIAS\components\Logging\NullLogger(),

components/ILIAS/Init/Init.php

@@ -120,7 +120,7 @@ public function init(
                 $pull[\ILIAS\UI\Implementation\Component\Progress\Factory::class],
                 $pull[\ILIAS\UI\Implementation\Component\Progress\State\Factory::class],
                 $pull[\ILIAS\UI\Implementation\Component\Progress\State\Bar\Factory::class],
-                $pull[\ILIAS\Cron\Registry::class],
+                $use[\ILIAS\Cron\Registry::class],
             );
     }
 }