Init: Use fallback plain text responder in worst case to report ilCtrl error

(cherry picked from commit fe44510)

Author: mjansenDatabay

components/ILIAS/Init/resources/ilias.php

@@ -21,19 +21,21 @@
 use ILIAS\HTTP\StatusCode;
 use ILIAS\Data\Factory as DataFactory;
 use ILIAS\Init\ErrorHandling\Http\ErrorPageResponder;
+use ILIAS\Init\ErrorHandling\Http\PlainTextFallbackResponder;
 
 if (!file_exists('../ilias.ini.php')) {
     die('The ILIAS setup is not completed. Please run the setup routine.');
 }
 
 require_once '../vendor/composer/vendor/autoload.php';
-require_once __DIR__ . '/../artifacts/bootstrap_default.php';
-entry_point('ILIAS Legacy Initialisation Adapter');
 
 /** @var \ILIAS\DI\Container $DIC */
 global $DIC;
 
 try {
+    require_once __DIR__ . '/../artifacts/bootstrap_default.php';
+    entry_point('ILIAS Legacy Initialisation Adapter');
+
     $DIC->ctrl()->callBaseClass();
 } catch (ilCtrlException $e) {
     if (defined('DEVMODE') && DEVMODE) {
@@ -50,16 +52,24 @@
         $df->uri(ILIAS_HTTP_PATH . '/ilias.php?baseClass=ilRepositoryGUI')
     );
 
-    new ErrorPageResponder(
-        $DIC->globalScreen(),
-        $DIC->language(),
-        $DIC->ui(),
-        $DIC->http()
-    )->respond(
-        $DIC->language()->txt('http_404_not_found'),
-        StatusCode::HTTP_NOT_FOUND,
-        $back_target
-    );
+    try {
+        new ErrorPageResponder(
+            $DIC->globalScreen(),
+            $DIC->language(),
+            $DIC->ui(),
+            $DIC->http()
+        )->respond(
+            $DIC->language()->txt('http_404_not_found'),
+            StatusCode::HTTP_NOT_FOUND,
+            $back_target
+        );
+    } catch (Throwable) {
+        new PlainTextFallbackResponder()->respond(
+            $e,
+            StatusCode::HTTP_NOT_FOUND,
+            $DIC->language()->txt('http_404_not_found')
+        );
+    }
 }
 
 $DIC['ilBench']->save();

components/ILIAS/Init/src/ErrorHandling/Http/PlainTextFallbackResponder.php

@@ -54,9 +54,12 @@ class PlainTextFallbackResponder
      * @param int $status_code HTTP status code (default: 500).
      * @throws Throwable in DEVMODE
      */
-    public function respond(Throwable $e, int $status_code = StatusCode::HTTP_INTERNAL_SERVER_ERROR): never
-    {
-        if (defined('DEVMODE') && DEVMODE) {
+    public function respond(
+        Throwable $e,
+        int $status_code = StatusCode::HTTP_INTERNAL_SERVER_ERROR,
+        ?string $status_message = null
+    ): never {
+        if (\defined('DEVMODE') && DEVMODE) {
             throw $e;
         }
 
@@ -65,12 +68,13 @@ public function respond(Throwable $e, int $status_code = StatusCode::HTTP_INTERN
             header('Content-Type: text/plain; charset=UTF-8');
         }
 
-        $incident_id = session_id() . '_' . (new \Random\Randomizer())->getInt(1, 9999);
+        $session_prefix = session_id() !== '' ? session_id() : 'no-session';
+        $incident_id = $session_prefix . '_' . (new \Random\Randomizer())->getInt(1, 9999);
         $timestamp = (new DateTimeImmutable())
             ->setTimezone(new DateTimeZone('UTC'))
             ->format('Y-m-d\TH:i:s\Z');
 
-        echo "Internal Server Error\n";
+        echo ($status_message ?? 'Internal Server Error') . "\n";
         echo "Incident: $incident_id\n";
         echo "Timestamp: $timestamp\n";
 
@@ -80,11 +84,12 @@ public function respond(Throwable $e, int $status_code = StatusCode::HTTP_INTERN
             echo "Message: {$e->getMessage()}\n";
         }
 
-        error_log(sprintf(
+        error_log(
+            \sprintf(
             "[%s] INCIDENT %s — Uncaught %s: %s in %s:%d\nStack trace:\n%s\n",
             $timestamp,
             $incident_id,
-            get_class($e),
+            \get_class($e),
             $e->getMessage(),
             $e->getFile(),
             $e->getLine(),