improve 47328: Failed test: Musterlösung

Author: alex40724

components/ILIAS/Exercise/Assignment/class.ilExAssignment.php

@@ -1476,6 +1476,8 @@ public static function sendFeedbackNotifications(
         global $DIC;
 
         $ilDB = $DIC->database();
+        $gui = $DIC->exercise()->internal()->gui();
+        $domain = $DIC->exercise()->internal()->domain();
         $log = ilLoggerFactory::getLogger("exc");
 
         $ass = new self($a_ass_id);
@@ -1504,6 +1506,24 @@ public static function sendFeedbackNotifications(
         $ntf->setSubjectLangId("exc_feedback_notification_subject");
         $ntf->setIntroductionLangId("exc_feedback_notification_body");
         $ntf->addAdditionalInfo("exc_assignment", $ass->getTitle());
+        $ref_id = 0;
+        if ($a_user_id) {   // link to assignment
+            $ref_id = $domain->permission()->getFirstRefIdWithPermission(
+                "read",
+                $ass->getExerciseId(),
+                $a_user_id
+            );
+        } else {
+            $ref_ids = ilObject::_getAllReferences($ass->getExerciseId());
+            if (count($ref_ids) === 1) {
+                $ref_id = current($ref_ids);
+            }
+        }
+        if ($ref_id > 0) {
+            $perm_link = $gui->permanentLink()->getPermanentLink($ref_id, $ass->getId());
+            $ntf->addAdditionalInfo("exc_link_to_assignment", $perm_link);
+        }
+
         $ntf->setGotoLangId("exc_feedback_notification_link");
         $ntf->setReasonLangId("exc_feedback_notification_reason");
 

components/ILIAS/Exercise/Permission/PermissionManager.php

@@ -0,0 +1,48 @@
+<?php
+
+/**
+ * This file is part of ILIAS, a powerful learning management system
+ * published by ILIAS open source e-Learning e.V.
+ *
+ * ILIAS is licensed with the GPL-3.0,
+ * see https://www.gnu.org/licenses/gpl-3.0.en.html
+ * You should have received a copy of said license along with the
+ * source code, too.
+ *
+ * If this is not the case or you just want to try ILIAS, you'll find
+ * us at:
+ * https://www.ilias.de
+ * https://github.com/ILIAS-eLearning
+ *
+ *********************************************************************/
+
+declare(strict_types=1);
+
+namespace ILIAS\Exercise\Permission;
+
+use ILIAS\ResourceStorage\Stakeholder\ResourceStakeholder;
+use ILIAS\Exercise\InternalDomainService;
+
+class PermissionManager
+{
+    public function __construct(
+        protected InternalDomainService $domain
+    ) {
+    }
+
+    public function getFirstRefIdWithPermission(
+        string $perm,
+        int $obj_id,
+        int $user_id
+    ): int {
+        $access = $this->domain->access();
+
+        foreach (\ilObject::_getAllReferences($obj_id) as $ref_id) {
+            if ($access->checkAccessOfUser($user_id, $perm, "", $ref_id)) {
+                return $ref_id;
+            }
+        }
+        return 0;
+    }
+
+}

components/ILIAS/Exercise/Service/classes/class.InternalDomainService.php

@@ -30,6 +30,7 @@
 use ILIAS\Exercise\PeerReview\DomainService;
 use ILIAS\Exercise\Settings\SettingsManager;
 use ILIAS\Exercise\User\UserEvent;
+use ILIAS\Exercise\Permission\PermissionManager;
 
 class InternalDomainService
 {
@@ -136,4 +137,11 @@ public function userEvent(): UserEvent
         );
     }
 
+    public function permission(): PermissionManager
+    {
+        return $this->instance["perm"] ??= new PermissionManager(
+            $this
+        );
+    }
+
 }

lang/ilias_de.lang

@@ -9403,6 +9403,7 @@ exc#:#exc_late_submission_warning#:#Abgaben nach %s werden als verspätet gekenn
 exc#:#exc_lead_request_idl#:#Abgabefrist anfragen
 exc#:#exc_lead_wait_for_idl#:#Wartet auf individuelle Abgabefrist
 exc#:#exc_limit_characters#:#Anzahl der Zeichen beschränken
+exc#:#exc_link_to_assignment#:#Link zur Übungseinheit
 exc#:#exc_list_submission#:#Alle Lösungsabgaben
 exc#:#exc_list_text_assignment#:#Liste aller Abgaben
 exc#:#exc_mail_context_grade_reminder_info#:#Personen, welche in einer Übungseinheit die Erinnerungen aktiviert haben, werden an die Bewertung der Einreichungen erinnert.

lang/ilias_en.lang

@@ -9377,6 +9377,7 @@ exc#:#exc_late_submission_warning#:#Submissions after %s are marked as late.
 exc#:#exc_lead_request_idl#:#Request Deadline
 exc#:#exc_lead_wait_for_idl#:#Waiting For Individual Deadline
 exc#:#exc_limit_characters#:#Limit of characters
+exc#:#exc_link_to_assignment#:#Link to assignment
 exc#:#exc_list_submission#:#List All Submissions
 exc#:#exc_list_text_assignment#:#List All Submissions
 exc#:#exc_mail_context_grade_reminder_info#:#Reminder Tutors/Teachers to Grade an Assignment