Skip to content

Commit f226c23

Browse files
committed
Update the build configuration and correct the path references
1 parent 19eca0b commit f226c23

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,8 +81,8 @@ python -m pip install seal-python
8181

8282
```shell
8383
# Run in "x64 Native Tools Command Prompt for VS" command prompt
84-
cmake -S . -B build -G Ninja -DSEAL_USE_MSGSL=OFF -DSEAL_USE_ZLIB=OFF
85-
cmake --build build
84+
cmake -S . -B build -G Ninja -DSEAL_USE_MSGSL=OFF -DSEAL_USE_ZLIB=OFF -DSEAL_USE_ZSTD=OFF
85+
cmake --build build --config Release
8686

8787
# Build
8888
pip install numpy pybind11

setup.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,13 @@
66
import sys
77
from setuptools import setup
88
from distutils.sysconfig import get_python_inc
9+
import pybind11
910
from pybind11.setup_helpers import Pybind11Extension, build_ext
1011

1112
__version__ = "4.1.2"
1213
BASE_DIR = Path(__file__).resolve().parent
1314

14-
include_dirs = [get_python_inc(), 'pybind11/include', 'SEAL/native/src', 'SEAL/build/native/src']
15+
include_dirs = [get_python_inc(), pybind11.get_include(), 'SEAL/native/src', 'SEAL/build/native/src']
1516

1617
if platform.system() == "Windows":
1718
extra_objects = sorted(
@@ -22,10 +23,10 @@
2223
else:
2324
extra_objects = sorted(glob('SEAL/build/lib/*.a'))
2425

25-
cpp_args = ['/std:c++latest'] if platform.system() == "Windows" else ['-std=c++17']
26+
cpp_args = ['/std:c++17', '/utf-8', '/bigobj'] if platform.system() == "Windows" else ['-std=c++17']
2627

2728
if len(extra_objects) < 1 or not os.path.exists(extra_objects[0]):
28-
print('Not found the seal lib file, check the `SEAL/build/lib`')
29+
print('Not found the seal lib file, check the "SEAL/build/lib"')
2930
sys.exit(1)
3031

3132

@@ -60,7 +61,7 @@ def _copy_typing_files(self):
6061
include_dirs=include_dirs,
6162
extra_compile_args=cpp_args,
6263
extra_objects=extra_objects,
63-
define_macros = [('VERSION_INFO', __version__)],
64+
define_macros=[('VERSION_INFO', __version__)],
6465
),
6566
]
6667

0 commit comments

Comments
 (0)