Remove unnecessary usages of DeferredParsingException which don't do

anything

Author: jasmith-hs

src/main/java/com/hubspot/jinjava/el/NoInvokeELResolver.java

@@ -1,6 +1,6 @@
 package com.hubspot.jinjava.el;
 
-import com.hubspot.jinjava.el.ext.DeferredParsingException;
+import com.hubspot.jinjava.interpret.DeferredValueException;
 import java.beans.FeatureDescriptor;
 import java.util.Iterator;
 import javax.el.ELContext;
@@ -49,7 +49,7 @@ public boolean isReadOnly(ELContext elContext, Object base, Object property) {
 
   @Override
   public void setValue(ELContext elContext, Object base, Object property, Object value) {
-    throw new DeferredParsingException("NoInvokeELResolver");
+    throw new DeferredValueException("NoInvokeELResolver");
   }
 
   @Override
@@ -60,6 +60,6 @@ public Object invoke(
     Class<?>[] paramTypes,
     Object[] params
   ) {
-    throw new DeferredParsingException("NoInvokeELResolver");
+    throw new DeferredValueException("NoInvokeELResolver");
   }
 }

src/main/java/com/hubspot/jinjava/el/ext/DeferredParsingException.java

@@ -8,13 +8,6 @@ public class DeferredParsingException extends DeferredValueException {
   private final Object sourceNode;
   private final IdentifierPreservationStrategy identifierPreservationStrategy;
 
-  public DeferredParsingException(String message) {
-    super(message);
-    this.deferredEvalResult = message;
-    this.sourceNode = null;
-    this.identifierPreservationStrategy = IdentifierPreservationStrategy.RESOLVING;
-  }
-
   public DeferredParsingException(Object sourceNode, String deferredEvalResult) {
     super(
       String.format(

src/main/java/com/hubspot/jinjava/lib/tag/ForTag.java

@@ -21,7 +21,6 @@
 import com.hubspot.jinjava.doc.annotations.JinjavaParam;
 import com.hubspot.jinjava.doc.annotations.JinjavaSnippet;
 import com.hubspot.jinjava.doc.annotations.JinjavaTextMateSnippet;
-import com.hubspot.jinjava.el.ext.DeferredParsingException;
 import com.hubspot.jinjava.interpret.DeferredValue;
 import com.hubspot.jinjava.interpret.DeferredValueException;
 import com.hubspot.jinjava.interpret.InterpretException;
@@ -143,15 +142,10 @@ public String interpretUnchecked(TagNode tagNode, JinjavaInterpreter interpreter
     List<String> loopVars = loopVarsAndExpression.getLeft();
     String loopExpression = loopVarsAndExpression.getRight();
 
-    Object collection;
-    try {
-      collection =
-        interpreter.resolveELExpression(loopExpression, tagNode.getLineNumber());
-    } catch (DeferredParsingException e) {
-      throw new DeferredParsingException(
-        String.format("%s in %s", String.join(", ", loopVars), e.getDeferredEvalResult())
-      );
-    }
+    Object collection = interpreter.resolveELExpression(
+      loopExpression,
+      tagNode.getLineNumber()
+    );
     return renderForCollection(tagNode, interpreter, loopVars, collection);
   }
 

src/main/java/com/hubspot/jinjava/random/DeferredRandomNumberGenerator.java

@@ -1,6 +1,6 @@
 package com.hubspot.jinjava.random;
 
-import com.hubspot.jinjava.el.ext.DeferredParsingException;
+import com.hubspot.jinjava.interpret.DeferredValueException;
 import java.util.Random;
 import java.util.stream.DoubleStream;
 import java.util.stream.IntStream;
@@ -15,42 +15,42 @@ public class DeferredRandomNumberGenerator extends Random {
 
   @Override
   protected int next(int bits) {
-    throw new DeferredParsingException(EXCEPTION_MESSAGE);
+    throw new DeferredValueException(EXCEPTION_MESSAGE);
   }
 
   @Override
   public int nextInt() {
-    throw new DeferredParsingException(EXCEPTION_MESSAGE);
+    throw new DeferredValueException(EXCEPTION_MESSAGE);
   }
 
   @Override
   public int nextInt(int bound) {
-    throw new DeferredParsingException(EXCEPTION_MESSAGE);
+    throw new DeferredValueException(EXCEPTION_MESSAGE);
   }
 
   @Override
   public long nextLong() {
-    throw new DeferredParsingException(EXCEPTION_MESSAGE);
+    throw new DeferredValueException(EXCEPTION_MESSAGE);
   }
 
   @Override
   public boolean nextBoolean() {
-    throw new DeferredParsingException(EXCEPTION_MESSAGE);
+    throw new DeferredValueException(EXCEPTION_MESSAGE);
   }
 
   @Override
   public float nextFloat() {
-    throw new DeferredParsingException(EXCEPTION_MESSAGE);
+    throw new DeferredValueException(EXCEPTION_MESSAGE);
   }
 
   @Override
   public double nextDouble() {
-    throw new DeferredParsingException(EXCEPTION_MESSAGE);
+    throw new DeferredValueException(EXCEPTION_MESSAGE);
   }
 
   @Override
   public synchronized double nextGaussian() {
-    throw new DeferredParsingException(EXCEPTION_MESSAGE);
+    throw new DeferredValueException(EXCEPTION_MESSAGE);
   }
 
   @Override