Migrate LegacyOverrides to Immutable

Author: jasmith-hs

src/main/java/com/hubspot/jinjava/LegacyOverrides.java

@@ -1,14 +1,18 @@
 package com.hubspot.jinjava;
 
-/**
- * This class allows Jinjava to be configured to override legacy behaviour.
- * LegacyOverrides.NONE signifies that none of the legacy functionality will be overridden.
- * LegacyOverrides.ALL signifies that all new functionality will be used; avoid legacy "bugs".
- */
-public class LegacyOverrides {
-
-  public static final LegacyOverrides NONE = new LegacyOverrides.Builder().build();
-  public static final LegacyOverrides THREE_POINT_0 = new LegacyOverrides.Builder()
+import com.hubspot.immutable.collection.encoding.ImmutableListEncodingEnabled;
+import com.hubspot.immutable.collection.encoding.ImmutableMapEncodingEnabled;
+import com.hubspot.immutable.collection.encoding.ImmutableSetEncodingEnabled;
+import org.immutables.value.Value;
+
+@Value.Immutable(singleton = true)
+@Value.Style(init = "with*", get = { "is*", "get*" })
+@ImmutableSetEncodingEnabled
+@ImmutableListEncodingEnabled
+@ImmutableMapEncodingEnabled
+public interface LegacyOverrides {
+  LegacyOverrides NONE = new Builder().build();
+  LegacyOverrides THREE_POINT_0 = new Builder()
     .withEvaluateMapKeys(true)
     .withIterateOverMapKeys(true)
     .withUsePyishObjectMapper(true)
@@ -19,7 +23,7 @@ public class LegacyOverrides {
     .withUseTrimmingForNotesAndExpressions(true)
     .withKeepNullableLoopValues(true)
     .build();
-  public static final LegacyOverrides ALL = new LegacyOverrides.Builder()
+  LegacyOverrides ALL = new Builder()
     .withEvaluateMapKeys(true)
     .withIterateOverMapKeys(true)
     .withUsePyishObjectMapper(true)
@@ -30,168 +34,55 @@ public class LegacyOverrides {
     .withUseTrimmingForNotesAndExpressions(true)
     .withKeepNullableLoopValues(true)
     .build();
-  private final boolean evaluateMapKeys;
-  private final boolean iterateOverMapKeys;
-  private final boolean usePyishObjectMapper;
-  private final boolean useSnakeCasePropertyNaming;
-  private final boolean whitespaceRequiredWithinTokens;
-  private final boolean useNaturalOperatorPrecedence;
-  private final boolean parseWhitespaceControlStrictly;
-  private final boolean allowAdjacentTextNodes;
-  private final boolean useTrimmingForNotesAndExpressions;
-  private final boolean keepNullableLoopValues;
-
-  private LegacyOverrides(Builder builder) {
-    evaluateMapKeys = builder.evaluateMapKeys;
-    iterateOverMapKeys = builder.iterateOverMapKeys;
-    usePyishObjectMapper = builder.usePyishObjectMapper;
-    useSnakeCasePropertyNaming = builder.useSnakeCasePropertyNaming;
-    whitespaceRequiredWithinTokens = builder.whitespaceRequiredWithinTokens;
-    useNaturalOperatorPrecedence = builder.useNaturalOperatorPrecedence;
-    parseWhitespaceControlStrictly = builder.parseWhitespaceControlStrictly;
-    allowAdjacentTextNodes = builder.allowAdjacentTextNodes;
-    useTrimmingForNotesAndExpressions = builder.useTrimmingForNotesAndExpressions;
-    keepNullableLoopValues = builder.keepNullableLoopValues;
-  }
-
-  public static Builder newBuilder() {
-    return new Builder();
-  }
 
-  public boolean isEvaluateMapKeys() {
-    return evaluateMapKeys;
+  @Value.Default
+  default boolean isEvaluateMapKeys() {
+    return false;
   }
 
-  public boolean isIterateOverMapKeys() {
-    return iterateOverMapKeys;
+  @Value.Default
+  default boolean isIterateOverMapKeys() {
+    return false;
   }
 
-  public boolean isUsePyishObjectMapper() {
-    return usePyishObjectMapper;
+  @Value.Default
+  default boolean isUsePyishObjectMapper() {
+    return false;
   }
 
-  public boolean isUseSnakeCasePropertyNaming() {
-    return useSnakeCasePropertyNaming;
+  @Value.Default
+  default boolean isUseSnakeCasePropertyNaming() {
+    return false;
   }
 
-  public boolean isWhitespaceRequiredWithinTokens() {
-    return whitespaceRequiredWithinTokens;
+  @Value.Default
+  default boolean isUseNaturalOperatorPrecedence() {
+    return false;
   }
 
-  public boolean isUseNaturalOperatorPrecedence() {
-    return useNaturalOperatorPrecedence;
+  @Value.Default
+  default boolean isParseWhitespaceControlStrictly() {
+    return false;
   }
 
-  public boolean isParseWhitespaceControlStrictly() {
-    return parseWhitespaceControlStrictly;
+  @Value.Default
+  default boolean isAllowAdjacentTextNodes() {
+    return false;
   }
 
-  public boolean isAllowAdjacentTextNodes() {
-    return allowAdjacentTextNodes;
+  @Value.Default
+  default boolean isUseTrimmingForNotesAndExpressions() {
+    return false;
   }
 
-  public boolean isUseTrimmingForNotesAndExpressions() {
-    return useTrimmingForNotesAndExpressions;
+  @Value.Default
+  default boolean isKeepNullableLoopValues() {
+    return false;
   }
 
-  public boolean isKeepNullableLoopValues() {
-    return keepNullableLoopValues;
-  }
-
-  public static class Builder {
-
-    private boolean evaluateMapKeys = false;
-    private boolean iterateOverMapKeys = false;
-    private boolean usePyishObjectMapper = false;
-    private boolean useSnakeCasePropertyNaming = false;
-    private boolean whitespaceRequiredWithinTokens = false;
-    private boolean useNaturalOperatorPrecedence = false;
-    private boolean parseWhitespaceControlStrictly = false;
-    private boolean allowAdjacentTextNodes = false;
-    private boolean useTrimmingForNotesAndExpressions = false;
-    private boolean keepNullableLoopValues = false;
-
-    private Builder() {}
-
-    public LegacyOverrides build() {
-      return new LegacyOverrides(this);
-    }
+  class Builder extends ImmutableLegacyOverrides.Builder {}
 
-    public static Builder from(LegacyOverrides legacyOverrides) {
-      return new Builder()
-        .withEvaluateMapKeys(legacyOverrides.evaluateMapKeys)
-        .withIterateOverMapKeys(legacyOverrides.iterateOverMapKeys)
-        .withUsePyishObjectMapper(legacyOverrides.usePyishObjectMapper)
-        .withUseSnakeCasePropertyNaming(legacyOverrides.useSnakeCasePropertyNaming)
-        .withWhitespaceRequiredWithinTokens(
-          legacyOverrides.whitespaceRequiredWithinTokens
-        )
-        .withUseNaturalOperatorPrecedence(legacyOverrides.useNaturalOperatorPrecedence)
-        .withParseWhitespaceControlStrictly(
-          legacyOverrides.parseWhitespaceControlStrictly
-        )
-        .withAllowAdjacentTextNodes(legacyOverrides.allowAdjacentTextNodes)
-        .withUseTrimmingForNotesAndExpressions(
-          legacyOverrides.useTrimmingForNotesAndExpressions
-        );
-    }
-
-    public Builder withEvaluateMapKeys(boolean evaluateMapKeys) {
-      this.evaluateMapKeys = evaluateMapKeys;
-      return this;
-    }
-
-    public Builder withIterateOverMapKeys(boolean iterateOverMapKeys) {
-      this.iterateOverMapKeys = iterateOverMapKeys;
-      return this;
-    }
-
-    public Builder withUsePyishObjectMapper(boolean usePyishObjectMapper) {
-      this.usePyishObjectMapper = usePyishObjectMapper;
-      return this;
-    }
-
-    public Builder withUseSnakeCasePropertyNaming(boolean useSnakeCasePropertyNaming) {
-      this.useSnakeCasePropertyNaming = useSnakeCasePropertyNaming;
-      return this;
-    }
-
-    public Builder withWhitespaceRequiredWithinTokens(
-      boolean whitespaceRequiredWithinTokens
-    ) {
-      this.whitespaceRequiredWithinTokens = whitespaceRequiredWithinTokens;
-      return this;
-    }
-
-    public Builder withUseNaturalOperatorPrecedence(
-      boolean useNaturalOperatorPrecedence
-    ) {
-      this.useNaturalOperatorPrecedence = useNaturalOperatorPrecedence;
-      return this;
-    }
-
-    public Builder withParseWhitespaceControlStrictly(
-      boolean parseWhitespaceControlStrictly
-    ) {
-      this.parseWhitespaceControlStrictly = parseWhitespaceControlStrictly;
-      return this;
-    }
-
-    public Builder withAllowAdjacentTextNodes(boolean allowAdjacentTextNodes) {
-      this.allowAdjacentTextNodes = allowAdjacentTextNodes;
-      return this;
-    }
-
-    public Builder withUseTrimmingForNotesAndExpressions(
-      boolean useTrimmingForNotesAndExpressions
-    ) {
-      this.useTrimmingForNotesAndExpressions = useTrimmingForNotesAndExpressions;
-      return this;
-    }
-
-    public Builder withKeepNullableLoopValues(boolean keepNullableLoopValues) {
-      this.keepNullableLoopValues = keepNullableLoopValues;
-      return this;
-    }
+  static Builder newBuilder() {
+    return new Builder();
   }
 }