HTMLAnchorElement: fix default port not stripped from host/port/origin

duonglaiquang · rbri · commit e523809d0665 · 2026-03-14T16:42:10.000+01:00
diff --git a/src/main/java/org/htmlunit/javascript/host/html/HTMLAnchorElement.java b/src/main/java/org/htmlunit/javascript/host/html/HTMLAnchorElement.java
@@ -55,6 +55,7 @@
  * @author Sudhan Moghe
  * @author Daniel Gredler
  * @author Ronald Brill
+ * @author Lai Quang Duong
  */
 @JsxClass(domClass = HtmlAnchor.class)
 public class HTMLAnchorElement extends HTMLElement {
@@ -318,7 +319,7 @@ public String getHost() {
             final int port = url.getPort();
             final String host = url.getHost();
 
-            if (port == -1) {
+            if (port == -1 || isDefaultPort(url.getProtocol(), port)) {
                 return host;
             }
             return host + ":" + port;
@@ -436,8 +437,9 @@ public void setPathname(final String pathname) throws Exception {
     @JsxGetter
     public String getPort() {
         try {
-            final int port = getUrl().getPort();
-            if (port == -1) {
+            final URL url = getUrl();
+            final int port = url.getPort();
+            if (port == -1 || isDefaultPort(url.getProtocol(), port)) {
                 return "";
             }
             return Integer.toString(port);
@@ -455,7 +457,14 @@ public String getPort() {
      */
     @JsxSetter
     public void setPort(final String port) throws Exception {
-        setUrl(UrlUtils.getUrlWithNewPort(getUrl(), Integer.parseInt(port)));
+        final URL url = getUrl();
+        final int newPort = Integer.parseInt(port);
+        if (isDefaultPort(url.getProtocol(), newPort)) {
+            setUrl(UrlUtils.getUrlWithNewPort(url, -1));
+        }
+        else {
+            setUrl(UrlUtils.getUrlWithNewPort(url, newPort));
+        }
     }
 
     /**
@@ -812,4 +821,15 @@ public DOMTokenList getRelList() {
     public void setRelList(final Object rel) {
         setRel(JavaScriptEngine.toString(rel));
     }
+
+    /**
+     * Checks whether the given port is the default port for the protocol.
+     * @param protocol the protocol (e.g. {@code "http"}, {@code "https"})
+     * @param port the port number
+     * @return {@code true} if the port is the default for the protocol
+     */
+    private static boolean isDefaultPort(final String protocol, final int port) {
+        return ("http".equals(protocol) && port == 80)
+                || ("https".equals(protocol) && port == 443);
+    }
 }
diff --git a/src/test/java/org/htmlunit/javascript/host/html/HTMLAnchorElement2Test.java b/src/test/java/org/htmlunit/javascript/host/html/HTMLAnchorElement2Test.java
@@ -1596,4 +1596,43 @@ public void readWriteAnchorHostnameEmpty() throws Exception {
         expandExpectedAlertsVariables("" + PORT);
         loadPageVerifyTitle2(html);
     }
+
+    /**
+     * @throws Exception if the test fails
+     */
+    @Test
+    @Alerts({"", "example.com", "", "example.com", "https://example.com",
+             "", "example.com", "https://example.com"})
+    public void defaultPortStripping() throws Exception {
+        final String html = DOCTYPE_HTML
+            + "<html><head>\n"
+            + "<script>\n"
+            + LOG_TITLE_FUNCTION
+            + "  function test() {\n"
+            // http:80 should be stripped
+            + "    var a = document.getElementById('a1');\n"
+            + "    log(a.port);\n"
+            + "    log(a.hostname);\n"
+            // https:443 should be stripped
+            + "    var b = document.getElementById('a2');\n"
+            + "    log(b.port);\n"
+            + "    log(b.host);\n"
+            + "    log(b.origin);\n"
+            // setPort to default should strip
+            + "    var c = document.getElementById('a3');\n"
+            + "    c.port = '443';\n"
+            + "    log(c.port);\n"
+            + "    log(c.host);\n"
+            + "    log(c.origin);\n"
+            + "  }\n"
+            + "</script>\n"
+            + "</head>\n"
+            + "<body onload='test()'>\n"
+            + "  <a id='a1' href='http://example.com:80/path'>link 1</a>\n"
+            + "  <a id='a2' href='https://example.com:443/path'>link 2</a>\n"
+            + "  <a id='a3' href='https://example.com:9000/path'>link 3</a>\n"
+            + "</body></html>";
+
+        loadPageVerifyTitle2(html);
+    }
 }
diff --git a/src/test/java/org/htmlunit/javascript/host/html/HTMLAnchorElementTest.java b/src/test/java/org/htmlunit/javascript/host/html/HTMLAnchorElementTest.java
@@ -141,9 +141,9 @@ public void readWriteAnchorPort() throws Exception {
             + "</body></html>";
         final HtmlPage page = loadPage(getBrowserVersion(), html, null, URL_GARGOYLE);
         HtmlAnchor link = page.getAnchors().get(0);
-        assertEquals("http://www.gargoylesoftware.com:80/foo.html#O", link.getHrefAttribute());
+        assertEquals("http://www.gargoylesoftware.com/foo.html#O", link.getHrefAttribute());
         link = page.getAnchors().get(1);
-        assertEquals("http://www.gargoylesoftware.com:8080/foo.html#O", link.getHrefAttribute());
+        assertEquals("http://www.gargoylesoftware.com/foo.html#O", link.getHrefAttribute());
     }
 
     /**
@@ -198,7 +198,7 @@ public void readWriteAnchorHost() throws Exception {
         link = page.getAnchors().get(1);
         assertEquals("http://www.gargoylesoftware.commotion/foo.html#O", link.getHrefAttribute());
         link = page.getAnchors().get(2);
-        assertEquals("http://www.gargoylesoftware.com:8080/foo.html#O", link.getHrefAttribute());
+        assertEquals("http://www.gargoylesoftware.com80/foo.html#O", link.getHrefAttribute());
         link = page.getAnchors().get(3);
         assertEquals("http://www.gargoylesoftware.com/foo.html#O", link.getHrefAttribute());
     }
