fix validation of has selector (and also for the pseudo element selector)

rbri · rbri · commit bba8159db092 · 2025-10-04T16:20:32.000+02:00
diff --git a/src/main/java/org/htmlunit/css/CssStyleSheet.java b/src/main/java/org/htmlunit/css/CssStyleSheet.java
@@ -1171,6 +1171,19 @@ private static boolean isValidSelector(final Selector selector, final DomNode do
                 final GeneralAdjacentSelector gas = (GeneralAdjacentSelector) selector;
                 return isValidSelector(gas.getSelector(), domNode)
                         && isValidSelector(gas.getSimpleSelector(), domNode);
+            case PSEUDO_ELEMENT_SELECTOR:
+                // as of now (4.17) the htmlunit-cssparser accepts only supported selectors
+                // if ("first-line".equals(s)
+                //         || "first-letter".equals(s)
+                //         || "before".equals(s)
+                //         || "after".equals(s))
+                //     {
+                //         return new PseudoElementSelector(s, locator, doubleColon);
+                //     }
+                return true;
+            case RELATIVE_SELECTOR:
+                final RelativeSelector rs = (RelativeSelector) selector;
+                return isValidSelector(rs.getSelector(), domNode);
             default:
                 if (LOG.isWarnEnabled()) {
                     LOG.warn("Unhandled CSS selector type '"
diff --git a/src/test/java/org/htmlunit/javascript/host/css/CSSSelector3Test.java b/src/test/java/org/htmlunit/javascript/host/css/CSSSelector3Test.java
@@ -790,6 +790,34 @@ public void hasAnd() throws Exception {
         loadPageVerifyTitle2(html);
     }
 
+
+    /**
+     * @throws Exception if the test fails
+     */
+    @Test
+    @Alerts({"0", "SyntaxError/DOMException"})
+    public void hasSizzleJQuery182InvalidContains() throws Exception {
+        final String html = DOCTYPE_HTML
+                + "<html>\n"
+                + "<head></head>\n"
+                + "<body>\n"
+
+                + "<script>\n"
+                + LOG_TITLE_FUNCTION
+                + "  try {\n"
+                + "    items = document.querySelectorAll(\"#form select:has(option:first-child)\");"
+                + "    log(items.length);\n"
+
+                + "    items = document.querySelectorAll(\"#form select:has(option:first-child:contains('o'))\");"
+                + "    log(items.length);\n"
+                + "  } catch (e) { logEx(e); }\n"
+                + "</script>\n"
+
+                + "</body></html>";
+
+        loadPageVerifyTitle2(html);
+    }
+
     /**
      * @throws Exception if the test fails
      */
