HtmlElement: fix a bug where input event not fired with type=email/url/date/time

duonglaiquang · rbri · commit b04cabbe9185 · 2026-03-13T08:42:12.000+01:00
diff --git a/src/main/java/org/htmlunit/html/HtmlElement.java b/src/main/java/org/htmlunit/html/HtmlElement.java
@@ -592,12 +592,8 @@ private Page type(final char c, final boolean lastType)
         }
 
         final WebClient webClient = page.getWebClient();
-        if (this instanceof HtmlTextInput
-                || this instanceof HtmlTextArea
-                || this instanceof HtmlTelInput
-                || this instanceof HtmlNumberInput
-                || this instanceof HtmlSearchInput
-                || this instanceof HtmlPasswordInput) {
+        if (this instanceof HtmlSelectableTextInput
+                || this instanceof HtmlTextArea) {
             fireEvent(new KeyboardEvent(this, Event.TYPE_INPUT, c,
                                         shiftPressed_ || isShiftNeeded, ctrlPressed_, altPressed_));
         }
diff --git a/src/test/java/org/htmlunit/html/HtmlElementTest.java b/src/test/java/org/htmlunit/html/HtmlElementTest.java
@@ -1269,4 +1269,27 @@ public void acceptChar() throws Exception {
         input.type(value);
         assertEquals(value, input.getValue());
     }
+
+    /**
+     * @throws Exception if an error occurs
+     */
+    @Test
+    public void typeFiresInputEvent() throws Exception {
+        final String[] types = {"text", "tel", "number", "search", "password", "email", "url", "date", "time"};
+
+        for (final String type : types) {
+            final String html = DOCTYPE_HTML
+                + "<html><body>\n"
+                + "<input type='" + type + "' id='t'>\n"
+                + "<script>\n"
+                + "  document.getElementById('t').addEventListener('input', function() {\n"
+                + "    document.title += 'input';\n"
+                + "  });\n"
+                + "</script>\n"
+                + "</body></html>";
+            final HtmlPage page = loadPage(html);
+            page.getHtmlElementById("t").type("ab");
+            assertEquals("input event for type=" + type, "inputinput", page.getTitleText());
+        }
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -592,12 +592,8 @@ private Page type(final char c, final boolean lastType)`
`592`	`592`	`}`
`593`	`593`
`594`	`594`	`final WebClient webClient = page.getWebClient();`
`595`		`- if (this instanceof HtmlTextInput`
`596`		`- \|\| this instanceof HtmlTextArea`
`597`		`- \|\| this instanceof HtmlTelInput`
`598`		`- \|\| this instanceof HtmlNumberInput`
`599`		`- \|\| this instanceof HtmlSearchInput`
`600`		`- \|\| this instanceof HtmlPasswordInput) {`
	`595`	`+ if (this instanceof HtmlSelectableTextInput`
	`596`	`+ \|\| this instanceof HtmlTextArea) {`
`601`	`597`	`fireEvent(new KeyboardEvent(this, Event.TYPE_INPUT, c,`
`602`	`598`	`shiftPressed_ \|\| isShiftNeeded, ctrlPressed_, altPressed_));`
`603`	`599`	`}`