Skip to content

Commit 96c054d

Browse files
committed
document more changes
1 parent 4bf3dbd commit 96c054d

2 files changed

Lines changed: 16 additions & 3 deletions

File tree

src/changes/changes.xml

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,21 @@
77
</properties>
88

99
<body>
10-
<release version="4.17.0" date="September xx, 2025" description="Chrome/Edge 140, Firefox 142, Bugfixes">
10+
<release version="4.17.0" date="September xx, 2025" description="Chrome/Edge 140, Firefox 142, css :has(), :is(), :where(), BroadcastChannel, Bugfixes">
11+
<action type="update" dev="Rene Schwietzke">
12+
Use a new HTMLElementsWithCache object for each neko parser run to avoid race conditions under load.
13+
</action>
14+
<action type="update" dev="Rene Schwietzke">
15+
neko: some optimizations for HTMLElementsProvider/HTMLElements/HTMLElementsWithCache.
16+
</action>
17+
<action type="add" dev="rbri">
18+
neko: introduce HTMLElementsProvider and HTMLElementsWithCache.
19+
</action>
1120
<action type="fix" dev="RhinoTeam">
12-
core-js: 'eval'of a function is now undefined
21+
core-js: 'eval'of a function is now undefined.
1322
</action>
1423
<action type="fix" dev="RhinoTeam">
15-
core-js: duplicate properties in object literal now allowed
24+
core-js: duplicate properties in object literal now allowed.
1625
</action>
1726
<action type="fix" dev="rbri">
1827
Window.top has no setter.

src/main/java/org/htmlunit/html/parser/neko/HtmlUnitNekoDOMBuilder.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,10 @@ public void pushInputString(final String html) {
207207
* @return the configuration
208208
*/
209209
private static XMLParserConfiguration createConfiguration(final BrowserVersion browserVersion) {
210+
// HTMLElements.HTMLElementsWithCache are not thread safe
211+
// because the cache is not synchronized
212+
// we have to create a new one for each parser run
213+
210214
if (browserVersion.hasFeature(HTML_COMMAND_TAG)) {
211215
return new HTMLConfiguration(new HTMLElements.HTMLElementsWithCache(HTMLELEMENTS_WITH_CMD));
212216
}

0 commit comments

Comments
 (0)