fix some pmd warnings

Author: rbri

src/main/java/org/htmlunit/html/HtmlAnchor.java

@@ -195,7 +195,7 @@ protected void doClickStateUpdate(final boolean shiftKey, final boolean ctrlKey,
             target = page.getResolvedTarget(getTargetAttribute());
         }
         page.getWebClient().download(page.getEnclosingWindow(), target, webRequest,
-                true, (ATTRIBUTE_NOT_DEFINED != downloadAttribute) ? downloadAttribute : null, "Link click");
+                true, (ATTRIBUTE_NOT_DEFINED == downloadAttribute) ? null : downloadAttribute, "Link click");
     }
 
     private boolean relContainsNoreferrer() {

src/main/java/org/htmlunit/html/XmlSerializer.java

@@ -125,10 +125,7 @@ protected void printXml(final DomElement node) throws IOException {
             builder_.append(indent_).append('<');
             printOpeningTag(node);
 
-            if (!hasChildren && !node.isEmptyXmlTagExpanded()) {
-                builder_.append("/>\n");
-            }
-            else {
+            if (hasChildren || node.isEmptyXmlTagExpanded()) {
                 builder_.append(">\n");
                 for (DomNode child = node.getFirstChild(); child != null; child = child.getNextSibling()) {
                     indent_.append("  ");
@@ -142,6 +139,9 @@ protected void printXml(final DomElement node) throws IOException {
                 }
                 builder_.append(indent_).append("</").append(node.getTagName()).append(">\n");
             }
+            else {
+                builder_.append("/>\n");
+            }
         }
     }
 
@@ -397,12 +397,12 @@ private File createFile(final String url, final String extension) throws IOExcep
         int counter = 0;
         while (true) {
             final String fileName;
-            if (counter != 0) {
-                fileName = StringUtils.substringBeforeLast(name, ".")
-                    + "_" + counter + "." + StringUtils.substringAfterLast(name, ".");
+            if (counter == 0) {
+                fileName = name;
             }
             else {
-                fileName = name;
+                fileName = StringUtils.substringBeforeLast(name, ".")
+                        + "_" + counter + "." + StringUtils.substringAfterLast(name, ".");
             }
             FileUtils.forceMkdir(outputDir_);
             final File f = new File(outputDir_, fileName);

src/main/java/org/htmlunit/html/serializer/HtmlSerializerNormalizedText.java

@@ -341,11 +341,11 @@ protected void appendTitle(final HtmlSerializerTextBuilder builder, final HtmlTi
     protected void appendTableRow(final HtmlSerializerTextBuilder builder, final HtmlTableRow htmlTableRow) {
         boolean first = true;
         for (final HtmlTableCell cell : htmlTableRow.getCells()) {
-            if (!first) {
-                builder.appendTab();
+            if (first) {
+                first = false;
             }
             else {
-                first = false;
+                builder.appendTab();
             }
             appendChildren(builder, cell); // trim?
         }

src/main/java/org/htmlunit/html/serializer/HtmlSerializerVisibleText.java

@@ -378,11 +378,11 @@ protected void appendTableRow(final HtmlSerializerTextBuilder builder,
             final HtmlTableRow htmlTableRow, final Mode mode) {
         boolean first = true;
         for (final HtmlTableCell cell : htmlTableRow.getCells()) {
-            if (!first) {
-                builder.appendBlank();
+            if (first) {
+                first = false;
             }
             else {
-                first = false;
+                builder.appendBlank();
             }
             appendChildren(builder, cell, mode); // trim?
         }

src/main/java/org/htmlunit/javascript/host/intl/Collator.java

@@ -46,7 +46,10 @@ public class Collator extends HtmlUnitScriptable {
     public static Scriptable jsConstructor(final Context cx, final Scriptable scope,
             final Object[] args, final Function ctorObj, final boolean inNewExpr) {
         final String[] locales;
-        if (args.length != 0) {
+        if (args.length == 0) {
+            locales = new String[] {""};
+        }
+        else {
             if (args[0] instanceof NativeArray) {
                 final NativeArray array = (NativeArray) args[0];
                 locales = new String[(int) array.getLength()];
@@ -58,9 +61,6 @@ public static Scriptable jsConstructor(final Context cx, final Scriptable scope,
                 locales = new String[] {JavaScriptEngine.toString(args[0])};
             }
         }
-        else {
-            locales = new String[] {""};
-        }
         final Window window = getWindow(ctorObj);
         final Collator format = new Collator(/*locales, window.getBrowserVersion()*/);
         format.setParentScope(window);

src/main/java/org/htmlunit/javascript/host/intl/NumberFormat.java

@@ -171,7 +171,10 @@ private static String getPattern(final Map<String, String> formats, final String
     public static Scriptable jsConstructor(final Context cx, final Scriptable scope,
             final Object[] args, final Function ctorObj, final boolean inNewExpr) {
         final String[] locales;
-        if (args.length != 0) {
+        if (args.length == 0) {
+            locales = new String[] {""};
+        }
+        else {
             if (args[0] instanceof NativeArray) {
                 final NativeArray array = (NativeArray) args[0];
                 locales = new String[(int) array.getLength()];
@@ -183,9 +186,6 @@ public static Scriptable jsConstructor(final Context cx, final Scriptable scope,
                 locales = new String[] {JavaScriptEngine.toString(args[0])};
             }
         }
-        else {
-            locales = new String[] {""};
-        }
         final Window window = getWindow(ctorObj);
         final NumberFormat format = new NumberFormat(locales, window.getBrowserVersion());
         format.setParentScope(window);

src/main/java/org/htmlunit/javascript/host/xml/XMLSerializer.java

@@ -201,7 +201,11 @@ else if (foredNamespace != null) {
                     break;
             }
         }
-        if (!startTagClosed) {
+
+        if (startTagClosed) {
+            builder.append("</").append(nodeName).append('>');
+        }
+        else {
             final String tagName = StringUtils.toRootLowerCase(nodeName);
             if (NON_EMPTY_TAGS.contains(tagName)) {
                 builder.append("></").append(nodeName).append('>');
@@ -210,9 +214,6 @@ else if (foredNamespace != null) {
                 builder.append(optionalPrefix).append("/>");
             }
         }
-        else {
-            builder.append("</").append(nodeName).append('>');
-        }
     }
 
 }