Skip to content

Commit 89dca58

Browse files
committed
time to remove IE (issue #735)
1 parent 823fbb8 commit 89dca58

5 files changed

Lines changed: 35 additions & 36 deletions

File tree

src/main/java/org/htmlunit/html/parser/neko/HtmlUnitNekoDOMBuilder.java

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -103,26 +103,15 @@ final class HtmlUnitNekoDOMBuilder extends AbstractSAXParser
103103

104104
static {
105105
// continue short code enumeration
106-
final short isIndexShortCode = HTMLElements.UNKNOWN + 1;
107-
final short commandShortCode = isIndexShortCode + 1;
108-
109-
// isIndex is special - we have to add it here because all browsers moving this to
110-
// the body (even if it is not supported)
111-
final HTMLElements.Element isIndex = new HTMLElements.Element(isIndexShortCode, "ISINDEX",
112-
HTMLElements.Element.CONTAINER, HTMLElements.BODY, null);
106+
final short commandShortCode = HTMLElements.UNKNOWN + 1;
113107

114108
final HTMLElements.Element command = new HTMLElements.Element(commandShortCode, "COMMAND",
115109
HTMLElements.Element.EMPTY, new short[] {HTMLElements.BODY, HTMLElements.HEAD}, null);
116110

117-
HTMLElements value;
118-
119-
value = new HTMLElements();
120-
value.setElement(isIndex);
121-
HTMLELEMENTS = value;
111+
HTMLELEMENTS = new HTMLElements();
122112

123-
value = new HTMLElements();
113+
final HTMLElements value = new HTMLElements();
124114
value.setElement(command);
125-
value.setElement(isIndex);
126115
HTMLELEMENTS_WITH_CMD = value;
127116
}
128117

src/test/java/org/htmlunit/general/ElementPropertiesTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8706,7 +8706,7 @@ public void geolocation() throws Exception {
87068706
}
87078707

87088708
/**
8709-
* Test {@link org.htmlunit.javascript.host.geo.Geolocation}.
8709+
* Test {@link org.htmlunit.javascript.host.xml.XMLHttpRequest}.
87108710
*
87118711
* @throws Exception if the test fails
87128712
*/

src/test/java/org/htmlunit/general/HostTypeOfTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2677,7 +2677,7 @@ public void geolocationPosition() throws Exception {
26772677
*/
26782678
@Test
26792679
@Alerts("function")
2680-
public void GeolocationPositionError() throws Exception {
2680+
public void geolocationPositionError() throws Exception {
26812681
test("GeolocationPositionError");
26822682
}
26832683

src/test/java/org/htmlunit/general/huge/HostParentOfFTest.java

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -262,4 +262,30 @@ public void _Geolocation_Geolocation() throws Exception {
262262
test("Geolocation", "Geolocation");
263263
}
264264

265+
/**
266+
* @throws Exception if the test fails
267+
*/
268+
@Test
269+
@Alerts("true")
270+
public void _GeolocationCoordinates_GeolocationCoordinates() throws Exception {
271+
test("GeolocationCoordinates", "GeolocationCoordinates");
272+
}
273+
274+
/**
275+
* @throws Exception if the test fails
276+
*/
277+
@Test
278+
@Alerts("true")
279+
public void _GeolocationPosition_GeolocationPosition() throws Exception {
280+
test("GeolocationPosition", "GeolocationPosition");
281+
}
282+
283+
/**
284+
* @throws Exception if the test fails
285+
*/
286+
@Test
287+
@Alerts("true")
288+
public void _GeolocationPositionError_GeolocationPositionError() throws Exception {
289+
test("GeolocationPositionError", "GeolocationPositionError");
290+
}
265291
}

src/test/java/org/htmlunit/general/huge/HostParentOfPTest.java

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -476,11 +476,7 @@ public void _Promise_Promise() throws Exception {
476476
* @throws Exception if the test fails
477477
*/
478478
@Test
479-
@Alerts(DEFAULT = "false",
480-
CHROME = "true",
481-
EDGE = "true",
482-
FF = "true",
483-
FF_ESR = "true")
479+
@Alerts("true")
484480
public void _PromiseRejectionEvent_PromiseRejectionEvent() throws Exception {
485481
test("PromiseRejectionEvent", "PromiseRejectionEvent");
486482
}
@@ -490,11 +486,7 @@ public void _PromiseRejectionEvent_PromiseRejectionEvent() throws Exception {
490486
* if the test fails
491487
*/
492488
@Test
493-
@Alerts(DEFAULT = "false",
494-
CHROME = "true",
495-
EDGE = "true",
496-
FF = "true",
497-
FF_ESR = "true")
489+
@Alerts("true")
498490
public void _PushManager_PushManager() throws Exception {
499491
test("PushManager", "PushManager");
500492
}
@@ -504,11 +496,7 @@ public void _PushManager_PushManager() throws Exception {
504496
* if the test fails
505497
*/
506498
@Test
507-
@Alerts(DEFAULT = "false",
508-
CHROME = "true",
509-
EDGE = "true",
510-
FF = "true",
511-
FF_ESR = "true")
499+
@Alerts("true")
512500
public void _PushSubscription_PushSubscription() throws Exception {
513501
test("PushSubscription", "PushSubscription");
514502
}
@@ -517,11 +505,7 @@ public void _PushSubscription_PushSubscription() throws Exception {
517505
* @throws Exception if the test fails
518506
*/
519507
@Test
520-
@Alerts(DEFAULT = "false",
521-
CHROME = "true",
522-
EDGE = "true",
523-
FF = "true",
524-
FF_ESR = "true")
508+
@Alerts("true")
525509
public void _PushSubscriptionOptions_PushSubscriptionOptions() throws Exception {
526510
test("PushSubscriptionOptions", "PushSubscriptionOptions");
527511
}

0 commit comments

Comments
 (0)