document last pr and add test

Author: rbri

src/changes/changes.xml

@@ -18,11 +18,14 @@
                 Jetty 9 websocket-client.
             </action>
 
+            <action type="fix" dev="Lai Quang Duong">
+                Restore the ability to specify null as password value (regression in 3.4.0).
+            </action>
             <action type="fix" dev="Lai Quang Duong" issue="https://github.com/HtmlUnit/htmlunit-neko/pull/92">
                 neko: infinity loop problem fixed while processing &lt;plaintext&gt; using document.write().
             </action>
             <action type="fix" dev="rbri" issue="#740">
-                Form elements available also when form detached from DOM (regression in 3.6.0).
+                Form elements available also when the form is detached from DOM (regression in 3.6.0).
             </action>
             <action type="update" dev="rbri">
                 Geoloction implementation changed, the location is now part of the WebClientOptions, means you can set the

src/main/java/org/htmlunit/httpclient/HtmlUnitUsernamePasswordCredentials.java

@@ -25,6 +25,7 @@
  * Wrapper for {@link UsernamePasswordCredentials} to avoid direct references spread around.
  *
  * @author Ronald Brill
+ * @author Lai Quang Duong
  */
 public class HtmlUnitUsernamePasswordCredentials implements Credentials, Serializable {
 
@@ -50,7 +51,9 @@ public HtmlUnitUsernamePasswordCredentials(final String userName, final String p
      * @param password the password
      */
     public HtmlUnitUsernamePasswordCredentials(final String userName, final char[] password) {
-        httpClientUsernamePasswordCredentials_ = new UsernamePasswordCredentials(userName, password != null ? String.valueOf(password) : null);
+        httpClientUsernamePasswordCredentials_ = new UsernamePasswordCredentials(
+                userName,
+                password == null ? null : String.valueOf(password));
     }
 
     @Override

src/test/java/org/htmlunit/DefaultCredentialsProviderTest.java

@@ -26,6 +26,7 @@
  * Tests for {@link DefaultCredentialsProvider}.
  *
  * @author Marc Guillemot
+ * @author Ronald Brill
  */
 @RunWith(BrowserRunner.class)
 public class DefaultCredentialsProviderTest extends SimpleWebTestCase {
@@ -94,4 +95,19 @@ public void removeCredentials() throws Exception {
         assertNull(credentials);
     }
 
+    /**
+     * @throws Exception if the test fails
+     */
+    @Test
+    public void passwordNull() throws Exception {
+        final String realm = "blah";
+        final String scheme = new BasicScheme().getSchemeName();
+
+        final DefaultCredentialsProvider provider = new DefaultCredentialsProvider();
+        provider.addCredentials("username", (char[]) null, HttpHeader.HOST_LC, 80, realm);
+
+        final Credentials credentials = provider.getCredentials(new AuthScope(HttpHeader.HOST_LC, 80, realm, scheme));
+        assertEquals("username", credentials.getUserPrincipal().getName());
+        assertNull(credentials.getPassword());
+    }
 }