pmd

Author: rbri

src/main/java/org/htmlunit/WebRequest.java

@@ -678,8 +678,9 @@ public void addHint(final HttpHint hint) {
     public String toString() {
         final StringBuilder builder = new StringBuilder(100)
                 .append(getClass().getSimpleName())
-                .append("[<url=\"").append(url_).append('"')
-                .append(", ").append(httpMethod_)
+                .append("[<url=\"")
+                .append(url_)
+                .append("\", ").append(httpMethod_)
                 .append(", ").append(encodingType_)
                 .append(", ").append(requestParameters_)
                 .append(", ").append(additionalHeaders_)

src/main/java/org/htmlunit/html/DefaultElementFactory.java

@@ -28,6 +28,7 @@
 import org.htmlunit.SgmlPage;
 import org.htmlunit.cyberneko.xerces.util.XMLAttributesImpl;
 import org.htmlunit.cyberneko.xerces.xni.QName;
+import org.htmlunit.source.ElementTestSource;
 import org.htmlunit.util.OrderedFastHashMap;
 import org.xml.sax.Attributes;
 
@@ -51,18 +52,12 @@
  */
 public class DefaultElementFactory implements ElementFactory {
 
-    // for performance optimization
-    static final class OrderedFastHashMapWithLowercaseKeys<K, V> extends OrderedFastHashMap<K, V> {
-        OrderedFastHashMapWithLowercaseKeys(final int size) {
-            super(size);
-        }
-    }
-
     /** Logging support. */
     private static final Log LOG = LogFactory.getLog(DefaultElementFactory.class);
 
     /**
-     * You can generate your own test cases by looking into ElementTestSource.generateTestForHtmlElements.
+     * You can generate your own test cases by looking into
+     * {@link ElementTestSource#generateTestForHtmlElements(String, String)}.
      */
     public static final List<String> SUPPORTED_TAGS_ = Collections.unmodifiableList(Arrays.asList(
         HtmlAbbreviated.TAG_NAME, HtmlAcronym.TAG_NAME,
@@ -118,6 +113,13 @@ static final class OrderedFastHashMapWithLowercaseKeys<K, V> extends OrderedFast
         HtmlVariable.TAG_NAME, HtmlVideo.TAG_NAME, HtmlWordBreak.TAG_NAME, HtmlExample.TAG_NAME
     ));
 
+    // for performance optimization
+    static final class OrderedFastHashMapWithLowercaseKeys<K, V> extends OrderedFastHashMap<K, V> {
+        OrderedFastHashMapWithLowercaseKeys(final int size) {
+            super(size);
+        }
+    }
+
     /**
      * @param page the owning page
      * @param tagName the HTML tag name

src/main/java/org/htmlunit/javascript/host/dom/DOMTokenList.java

@@ -260,7 +260,7 @@ public boolean replace(final String oldToken, final String newToken) {
         }
         final List<String> parts = split(value);
         final int pos = parts.indexOf(oldToken);
-        while (pos == -1) {
+        if (pos == -1) {
             return false;
         }