use our own string functions

Author: rbri

src/main/java/org/htmlunit/html/HtmlOutput.java

@@ -19,8 +19,8 @@
 import java.util.HashSet;
 import java.util.Map;
 
-import org.apache.commons.lang3.StringUtils;
 import org.htmlunit.SgmlPage;
+import org.htmlunit.util.StringUtils;
 
 /**
  * Wrapper for the HTML element "output".

src/main/java/org/htmlunit/httpclient/HtmlUnitSameSiteHandler.java

@@ -14,13 +14,13 @@
  */
 package org.htmlunit.httpclient;
 
-import org.apache.commons.lang3.StringUtils;
 import org.apache.http.cookie.CommonCookieAttributeHandler;
 import org.apache.http.cookie.Cookie;
 import org.apache.http.cookie.CookieOrigin;
 import org.apache.http.cookie.MalformedCookieException;
 import org.apache.http.cookie.SetCookie;
 import org.apache.http.impl.cookie.BasicClientCookie;
+import org.htmlunit.util.StringUtils;
 
 /**
  * Customized CookieAttributeHandler for handling of the samesite attribute.

src/test/java/org/htmlunit/archunit/ArchitectureTest.java

@@ -129,6 +129,14 @@ public class ArchitectureTest {
     public static final ArchRule apacheStringsContainsRule = noClasses()
         .should().callMethod(org.apache.commons.lang3.Strings.class, "contains", CharSequence.class, CharSequence.class);
 
+    /**
+     * Do not use org.apache.commons.lang3.StringUtils.toRootLowerCase(String).
+     */
+    @ArchTest
+    public static final ArchRule apacheStringstoRootLowerCaseRule = noClasses()
+        .should().callMethod(org.apache.commons.lang3.StringUtils.class, "toRootLowerCase", String.class);
+
+
     /**
      * The jetty websocket stuff is only used by one class.
      */