Skip to content

Commit 0bd1c04

Browse files
committed
document last changes
1 parent a493d00 commit 0bd1c04

4 files changed

Lines changed: 20 additions & 0 deletions

File tree

src/changes/changes.xml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,12 @@
88

99
<body>
1010
<release version="5.0.0" date="April 01, 2026" description="jdk17, Bugfixes">
11+
<action type="update" dev="Lai Quang Duong">
12+
Extract shared HTMLHyperlinkElementUtils for URL decomposition and use it from HTMLAnchorElement and HTMLAreaElement.
13+
</action>
14+
<action type="fix" dev="Lai Quang Duong">
15+
HTMLAnchorElement: strip default port from host/port/origin.
16+
</action>
1117
<action type="fix" dev="Lai Quang Duong">
1218
HtmlPage: fix a bug where async script may not be executed.
1319
</action>

src/main/java/org/htmlunit/javascript/host/html/HTMLHyperlinkElementUtils.java

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,18 @@
2525
* Provides URL decomposition property logic
2626
* @see <a href="https://html.spec.whatwg.org/multipage/links.html#htmlhyperlinkelementutils">
2727
* HTMLHyperlinkElementUtils</a>
28+
*
29+
* @author Lai Quang Duong
30+
* @author Ronald Brill
2831
*/
2932
final class HTMLHyperlinkElementUtils {
3033

34+
/**
35+
* Private ctor to keep Checkstyle happy
36+
*/
37+
private HTMLHyperlinkElementUtils() {
38+
}
39+
3140
/**
3241
* Returns the {@code search} component of the URL.
3342
* @param url the URL

src/test/java/org/htmlunit/archunit/ArchitectureTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,14 @@ public class ArchitectureTest {
6060
@ArchTest
6161
public static final ArchRule utilsPackageRule = classes()
6262
.that().haveNameMatching(".*Util.?")
63+
6364
.and().doNotHaveFullyQualifiedName("org.htmlunit.cssparser.util.ParserUtils")
6465
.and().doNotHaveFullyQualifiedName("org.htmlunit.http.HttpUtils")
6566
.and().doNotHaveFullyQualifiedName("org.htmlunit.util.brotli.Utils")
6667

68+
.and().doNotHaveFullyQualifiedName("org.htmlunit.javascript.host.html.HTMLHyperlinkElementUtils")
69+
70+
6771
.and().doNotHaveFullyQualifiedName("org.htmlunit.platform.font.AwtFontUtil")
6872
.and().doNotHaveFullyQualifiedName("org.htmlunit.platform.font.FontUtil")
6973
.and().doNotHaveFullyQualifiedName("org.htmlunit.platform.font.NoOpFontUtil")

src/test/java/org/htmlunit/javascript/host/html/HTMLAnchorElement2Test.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
* @author Ronald Brill
5151
* @author Marc Guillemot
5252
* @author Frank Danek
53+
* @author Lai Quang Duong
5354
*/
5455
public class HTMLAnchorElement2Test extends WebDriverTestCase {
5556

0 commit comments

Comments
 (0)