::not is invalid

Author: rbri

src/main/java/org/htmlunit/cssparser/parser/condition/NotPseudoClassCondition.java

@@ -21,25 +21,22 @@
 import org.htmlunit.cssparser.parser.selector.SelectorList;
 
 /**
- * Not condition.
+ * :not condition.
  *
  * @author Ronald Brill
  */
 public class NotPseudoClassCondition extends AbstractLocatable implements Condition, Serializable {
 
     private final SelectorList selectors_;
-    private final boolean doubleColon_;
 
     /**
      * Ctor.
      * @param selectors the selector list
      * @param locator the locator
-     * @param doubleColon true if was prefixed by double colon
      */
-    public NotPseudoClassCondition(final SelectorList selectors, final Locator locator, final boolean doubleColon) {
+    public NotPseudoClassCondition(final SelectorList selectors, final Locator locator) {
         selectors_ = selectors;
         setLocator(locator);
-        doubleColon_ = doubleColon;
     }
 
     @Override
@@ -72,6 +69,6 @@ public SelectorList getSelectors() {
 
     @Override
     public String toString() {
-        return (doubleColon_ ? "::" : ":") + "not(" + getValue() + ")";
+        return ":not(" + getValue() + ")";
     }
 }

src/main/javacc/CSS3Parser.jj

@@ -1444,7 +1444,8 @@ Object pseudo(boolean pseudoElementFound) :
                 <RROUND>
                 {
                     if (pseudoElementFound) { throw toCSSParseException("duplicatePseudo", new String[] { function + selectorList + ")" }, locator); }
-                    return new NotPseudoClassCondition(selectorList, locator, doubleColon);
+                    if (doubleColon) { throw toCSSParseException("invalidPseudoColon", new String[] { ":" + function + selectorList + ")" }, locator); }
+                    return new NotPseudoClassCondition(selectorList, locator);
                 }
             )
             |

src/test/java/org/htmlunit/cssparser/parser/CSS3ParserTest.java

@@ -3247,6 +3247,37 @@ public void invalid_not() throws Exception {
 //                + " Was expecting one of: <S>, \")\".)");
     }
 
+    /**
+     * @throws Exception if any error occurs
+     */
+    @Test
+    public void syntaxErrorDoubleColon() throws Exception {
+        String selector = "::not(h2)";
+
+        final CSSOMParser parser = new CSSOMParser();
+        ErrorHandler errorHandler = new ErrorHandler();
+        parser.setErrorHandler(errorHandler);
+
+        parser.parseSelectors(selector);
+
+        assertEquals(1, errorHandler.getErrorCount());
+        assertEquals(0, errorHandler.getFatalErrorCount());
+        assertEquals(0, errorHandler.getWarningCount());
+
+        assertEquals("\"::not(h2)\" is not a valid selector.", errorHandler.getErrorMessage());
+
+        selector = "p::not(h4)";
+        errorHandler = new ErrorHandler();
+        parser.setErrorHandler(errorHandler);
+        parser.parseSelectors(selector);
+
+        assertEquals(1, errorHandler.getErrorCount());
+        assertEquals(0, errorHandler.getFatalErrorCount());
+        assertEquals(0, errorHandler.getWarningCount());
+
+        assertEquals("\"::not(h4)\" is not a valid selector.", errorHandler.getErrorMessage());
+    }
+
     /**
      * @throws Exception if any error occurs
      */

src/test/java/org/htmlunit/cssparser/parser/selector/SelectorSpecificityTest.java

@@ -210,6 +210,8 @@ public void notTest() throws Exception {
         selectorSpecifity("div:not(.inner) p", "0,0,1,2");
         selectorSpecifity("div:not(.inner, #fakeId) p", "0,1,1,2");
         selectorSpecifity("a:not(#fakeId#fakeId#fakeID)", "0,3,0,1");
+
+        selectorSpecifity("#foo:not(#bar)", "0,2,0,0");
     }
 
     /**