Improve JS examples

Author: tshemsedinov

JavaScript/1-execute.js

@@ -37,9 +37,9 @@ class Bank {
     this.commands = [];
   }
 
-  operation(account, amount) {
-    const Command = amount < 0 ? Withdraw : Income;
-    const command = new Command(account, Math.abs(amount));
+  operation(account, value) {
+    const Command = value < 0 ? Withdraw : Income;
+    const command = new Command(account, Math.abs(value));
     command.execute();
     this.commands.push(command);
   }

JavaScript/2-undo.js

@@ -47,9 +47,9 @@ class Bank {
     this.commands = [];
   }
 
-  operation(account, amount) {
-    const Command = amount < 0 ? Withdraw : Income;
-    const command = new Command(account, Math.abs(amount));
+  operation(account, value) {
+    const Command = value < 0 ? Withdraw : Income;
+    const command = new Command(account, Math.abs(value));
     command.execute();
     this.commands.push(command);
   }

JavaScript/3-anemic.js

@@ -20,13 +20,11 @@ class Bank {
     this.commands = [];
   }
 
-  operation(account, amount) {
-    const operation = amount < 0 ? 'withdraw' : 'income';
-    const command = new AccountCommand(
-      operation,
-      account.name,
-      Math.abs(amount),
-    );
+  operation(account, value) {
+    const operation = value < 0 ? 'withdraw' : 'income';
+    const amount = Math.abs(value);
+    const { name } = account;
+    const command = new AccountCommand(operation, name, amount);
     this.commands.push(command);
     account.balance += amount;
   }

JavaScript/4-operations.js

@@ -39,14 +39,12 @@ class Bank {
     this.commands = [];
   }
 
-  operation(account, amount) {
-    const operation = amount < 0 ? 'withdraw' : 'income';
+  operation(account, value) {
+    const operation = value < 0 ? 'withdraw' : 'income';
     const execute = OPERATIONS[operation];
-    const command = new AccountCommand(
-      operation,
-      account.name,
-      Math.abs(amount),
-    );
+    const amount = Math.abs(value);
+    const { name } = account;
+    const command = new AccountCommand(operation, name, amount);
     const check = OPERATIONS.allowed;
     const allowed = check(command);
     if (!allowed) {

JavaScript/5-undo.js

@@ -50,14 +50,12 @@ class Bank {
     this.commands = [];
   }
 
-  operation(account, amount) {
-    const operation = amount < 0 ? 'withdraw' : 'income';
+  operation(account, value) {
+    const operation = value < 0 ? 'withdraw' : 'income';
     const { execute } = OPERATIONS[operation];
-    const command = new AccountCommand(
-      operation,
-      account.name,
-      Math.abs(amount),
-    );
+    const amount = Math.abs(value);
+    const { name } = account;
+    const command = new AccountCommand(operation, name, amount);
     this.commands.push(command);
     execute(command);
   }

JavaScript/6-js-way.js

@@ -36,14 +36,12 @@ class Bank {
     this.commands = [];
   }
 
-  operation(account, amount) {
-    const operation = amount < 0 ? 'withdraw' : 'income';
+  operation(account, value) {
+    const operation = value < 0 ? 'withdraw' : 'income';
     const { execute } = OPERATIONS[operation];
-    const command = {
-      operation,
-      account: account.name,
-      amount: Math.abs(amount),
-    };
+    const amount = Math.abs(value);
+    const { name } = account;
+    const command = { operation, account: name, amount };
     this.commands.push(command);
     execute(command);
   }