Update application/src/main/java/org/opentripplanner/routing/graphfinder/ChronologicalGraphPath.java

vpaturet · t2gran · web-flow · commit 7af76b43bc5d · 2026-03-31T15:39:48.000+02:00
Co-authored-by: Thomas Gran &lt;t2gran@gmail.com&gt;
diff --git a/application/src/main/java/org/opentripplanner/routing/graphfinder/ChronologicalGraphPath.java b/application/src/main/java/org/opentripplanner/routing/graphfinder/ChronologicalGraphPath.java
@@ -47,6 +47,8 @@ static ChronologicalGraphPath of(State state) {
     // For depart-after, edges are in reverse chronological order; reverse to chronological.
     // For arriveBy, the A* searched backward so edges are already chronological.
     if (!state.getRequest().arriveBy()) {
+      // We considered using `ArrayList.reversed()` (view) here, but there is no significant performance gain
+      // and the graph deserialization would break. See PR #7455.
       Collections.reverse(edges);
     }
     return new ChronologicalGraphPath(edges, walkDistance);

Original file line number	Diff line number	Diff line change
`@@ -47,6 +47,8 @@ static ChronologicalGraphPath of(State state) {`
`47`	`47`	`// For depart-after, edges are in reverse chronological order; reverse to chronological.`
`48`	`48`	`// For arriveBy, the A* searched backward so edges are already chronological.`
`49`	`49`	`if (!state.getRequest().arriveBy()) {`
	`50`	+ // We considered using `ArrayList.reversed()` (view) here, but there is no significant performance gain
	`51`	`+ // and the graph deserialization would break. See PR #7455.`
`50`	`52`	`Collections.reverse(edges);`
`51`	`53`	`}`
`52`	`54`	`return new ChronologicalGraphPath(edges, walkDistance);`