Skip to content

Commit 7a46e43

Browse files
committed
Bump AsyncWebServerUtils
1 parent 972ea8e commit 7a46e43

5 files changed

Lines changed: 12 additions & 12 deletions

File tree

platformio.ini

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ lib_deps =
1919
https://github.com/mathieucarbou/AsyncTCP.git#v3.2.4
2020
https://github.com/mathieucarbou/ESPAsyncWebServer.git#v3.1.5
2121
https://github.com/GuLinux/AsyncBufferedTcpLogger#v0.0.2
22-
https://github.com/GuLinux/AsyncWebserverUtils#v0.0.2
22+
https://github.com/GuLinux/AsyncWebserverUtils#v0.0.3
2323
https://github.com/GuLinux/WiFiManager.git#v0.0.1
2424
https://github.com/GuLinux/ArduinoOTA-Manager.git#v0.0.1
2525
ayushsharma82/ElegantOTA @ 3.1.1

src/heater.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ bool APB::Heater::active() const {
112112
return d->getDuty() > 0;
113113
}
114114

115-
void APB::Heater::setDuty(float duty) {
115+
void APB::Heater::setMaxDuty(float duty) {
116116
if(duty > 0) {
117117
d->maxDuty = duty;
118118
d->mode = Heater::Mode::fixed;
@@ -222,7 +222,7 @@ void APB::Heater::Private::loop()
222222
// From nmow on we require a temperature sensor on the heater
223223
if(!temperature) {
224224
Log.warningln("%s Unable to set target temperature, sensor not found.", log_scope);
225-
q->setDuty(0);
225+
q->setMaxDuty(0);
226226
return;
227227
}
228228

@@ -233,7 +233,7 @@ void APB::Heater::Private::loop()
233233
if(mode == Heater::Mode::dewpoint) {
234234
if(!Ambient::Instance.reading()) {
235235
Log.warningln("%s Unable to set target temperature, ambient sensor not found.", log_scope);
236-
q->setDuty(0);
236+
q->setMaxDuty(0);
237237
return;
238238
}
239239
dynamicTargetTemperature = dewpointOffset + Ambient::Instance.reading()->dewpoint();

src/heater.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class Heater {
2929

3030
float maxDuty() const;
3131
float duty() const;
32-
void setDuty(float duty);
32+
void setMaxDuty(float duty);
3333
bool setTemperature(float targetTemperature, float maxDuty=1, float minDuty=0, float rampOffset=0);
3434
bool setDewpoint(float offset, float maxDuty=1, float minDuty=0, float rampOffset=0);
3535
std::optional<float> temperature() const;

src/webserver.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -287,23 +287,23 @@ void APB::WebServer::onPostSetHeater(AsyncWebServerRequest *request, JsonVariant
287287
Validation validation{request, json};
288288
if(validation.required<int>("index").required<const char*>("mode")
289289
.range("index", {0}, {Heaters::Instance.size()-1})
290-
.range("duty", {0}, {1})
290+
.range("max_duty", {0}, {1})
291291
.choice("mode", Heater::validModes()).invalid()) return;
292292
Heater &heater = Heaters::Instance[json["index"]];
293293
Heater::Mode mode = Heater::modeFromString(json["mode"]);
294294
if(mode == Heater::Mode::off) {
295-
heater.setDuty(0);
295+
heater.setMaxDuty(0);
296296
onGetHeaters(request);
297297
return;
298298
}
299299

300-
if(validation.range("duty", {0}, {1}).required<float>("duty").invalid()) return;
301-
float duty = json["duty"];
300+
if(validation.range("max_duty", {0}, {1}).required<float>("max_duty").invalid()) return;
301+
float duty = json["max_duty"];
302302
static const char *temperatureErrorMessage = "Unable to set target temperature. Heater probably doesn't have a temperature sensor.";
303303
static const char *dewpointTemperatureErrorMessage = "Unable to set target temperature. Either the heater doesn't have a temperature sensor, or you're missing an ambient sensor.";
304304

305305
if(mode == Heater::Mode::fixed) {
306-
heater.setDuty(json["duty"]);
306+
heater.setMaxDuty(json["max_duty"]);
307307
}
308308
if(mode == Heater::Mode::dewpoint) {
309309
if(validation

web/src/features/sensors/heaters/Heaters.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,8 @@ const SetHeaterModal = ({heater: originalHeater, show, onClose, index}) => {
104104
<Collapse in={heater.mode !== 'off'}>
105105
<Form.Group className='mb-3'>
106106
<Form.Label>Duty</Form.Label>
107-
<Badge className='float-end'><Number value={heater.duty} formatFunction={formatPercentage} decimals={1} /></Badge>
108-
<Form.Range min={0} max={1} step={0.001} value={heater.duty} onChange={updateHeater('duty', parseFloat)} />
107+
<Badge className='float-end'><Number value={heater.max_duty} formatFunction={formatPercentage} decimals={1} /></Badge>
108+
<Form.Range min={0} max={1} step={0.001} value={heater.max_duty} onChange={updateHeater('max_duty', parseFloat)} />
109109
{ ['target_temperature', 'dewpoint'].includes(heater.mode) &&
110110
<Form.Text>When ramp is set to a non zero value, and mode is either <code>Dewpoint offset</code> or <code>Target temperature</code>,
111111
this will be a maximum value rather than the real duty.</Form.Text> }

0 commit comments

Comments
 (0)