重构

Author: GcsSloop

diycode-app/src/main/java/com/gcssloop/diycode/base/app/BaseFragment.java

@@ -31,6 +31,10 @@
 import android.view.ViewGroup;
 import android.widget.Toast;
 
+import com.gcssloop.diycode.utils.Config;
+import com.gcssloop.diycode.utils.DataCache;
+import com.gcssloop.diycode_sdk.api.Diycode;
+
 /**
  * 提供基础内容和生命周期控制
  */
@@ -39,6 +43,18 @@ public abstract class BaseFragment extends Fragment {
     private Bundle mSavedState;         // 存储状态信息
     private ViewHolder mViewHolder;     // View 管理
 
+    // 数据
+    protected Config mConfig;         // 配置(状态信息)
+    protected Diycode mDiycode;       // 在线(服务器)
+    protected DataCache mDataCache;   // 缓存(本地)
+
+    @Override public void onCreate(@Nullable Bundle savedInstanceState) {
+        super.onCreate(savedInstanceState);
+        mConfig = Config.getSingleInstance();
+        mDiycode = Diycode.getSingleInstance();
+        mDataCache = new DataCache(getContext());
+    }
+
     @LayoutRes
     protected abstract int getLayoutId();
 

diycode-app/src/main/java/com/gcssloop/diycode/fragment/TopicListFragment.java

@@ -25,16 +25,12 @@
 import android.content.Context;
 import android.os.Bundle;
 import android.support.annotation.NonNull;
-import android.support.annotation.Nullable;
 import android.support.v7.widget.RecyclerView;
 import android.view.View;
 
 import com.gcssloop.diycode.R;
 import com.gcssloop.diycode.base.recyclerview.SpeedyLinearLayoutManager;
 import com.gcssloop.diycode.fragment.provider.TopicProvider;
-import com.gcssloop.diycode.utils.Config;
-import com.gcssloop.diycode.utils.DataCache;
-import com.gcssloop.diycode_sdk.api.Diycode;
 import com.gcssloop.diycode_sdk.api.topic.bean.Topic;
 import com.gcssloop.diycode_sdk.api.topic.event.GetTopicsListEvent;
 import com.gcssloop.diycode_sdk.log.Logger;
@@ -46,10 +42,6 @@
 public class TopicListFragment extends RefreshRecyclerFragment<Topic, GetTopicsListEvent> {
 
     private boolean isFirstLaunch = true;
-    // 数据
-    private Config mConfig;         // 配置(状态信息)
-    private Diycode mDiycode;       // 在线(服务器)
-    private DataCache mDataCache;   // 缓存(本地)
 
     public static TopicListFragment newInstance() {
         Bundle args = new Bundle();
@@ -58,14 +50,6 @@ public static TopicListFragment newInstance() {
         return fragment;
     }
 
-    @Override
-    public void onCreate(@Nullable Bundle savedInstanceState) {
-        super.onCreate(savedInstanceState);
-        mConfig = Config.getSingleInstance();
-        mDiycode = Diycode.getSingleInstance();
-        mDataCache = new DataCache(getContext());
-    }
-
     @Override
     public void initData(HeaderFooterAdapter adapter) {
         List<Topic> topics = mDataCache.getTopicsList();
@@ -75,10 +59,7 @@ public void initData(HeaderFooterAdapter adapter) {
             adapter.addDatas(topics);
             if (isFirstLaunch) {
                 int lastPosition = mConfig.getTopicListLastPosition();
-                int lastOffset = mConfig.getTopicListLastOffset();
-                if (lastPosition != 0) {
-                    mRecyclerView.getLayoutManager().scrollToPosition(lastPosition);
-                }
+                mRecyclerView.getLayoutManager().scrollToPosition(lastPosition);
                 isFirstAddFooter = false;
                 isFirstLaunch = false;
             }
@@ -100,7 +81,6 @@ protected RecyclerView.LayoutManager getRecyclerViewLayoutManager() {
         return new SpeedyLinearLayoutManager(getContext());
     }
 
-
     @NonNull
     @Override
     protected String request(int offset, int limit) {
@@ -132,7 +112,6 @@ protected void onError(GetTopicsListEvent event, String postType) {
         }
     }
 
-    @SuppressWarnings("unchecked")
     public ArrayList<Topic> convert(List<Object> objects) {
         ArrayList<Topic> topics = new ArrayList<>();
         for (Object obj : objects) {
@@ -153,11 +132,8 @@ private void saveState() {
         // 存储 PageIndex
         mConfig.saveTopicListPageIndex(pageIndex);
         // 存储 RecyclerView 滚动位置
-        RecyclerView.LayoutManager layoutManager = mRecyclerView.getLayoutManager();
-        View view = layoutManager.getChildAt(0);
-        int lastPosition = layoutManager.getPosition(view);
-        int lastOffset = view.getTop();
-        mConfig.saveTopicListState(lastPosition, lastOffset);
-        Logger.e("onDestroyView", lastPosition + " : " + lastOffset);
+        View view = mRecyclerView.getLayoutManager().getChildAt(0);
+        int lastPosition = mRecyclerView.getLayoutManager().getPosition(view);
+        mConfig.saveTopicListState(lastPosition, 0);
     }
 }