Skip to content

Commit fffaf9b

Browse files
committed
Better error handling
1 parent 1abfdbd commit fffaf9b

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

remmina/src/remmina_ssh_plugin.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -410,12 +410,16 @@ remmina_plugin_ssh_vte_save_session (GtkMenuItem *menuitem, RemminaProtocolWidge
410410
TRACE_CALL(__func__);
411411
RemminaPluginSshData *gpdata = GET_PLUGIN_DATA(gp);
412412

413+
GtkWidget* widget;
413414
GError* err = NULL;
414415

415416
GFileOutputStream *stream = g_file_replace(gpdata->vte_session_file, NULL, FALSE, G_FILE_CREATE_NONE, NULL, &err);
416417

417418
if (err != NULL) {
418-
remmina_plugin_service->protocol_plugin_set_error (gp, "%s", err->message);
419+
widget = gtk_message_dialog_new(NULL, GTK_DIALOG_MODAL, GTK_MESSAGE_ERROR, GTK_BUTTONS_OK,
420+
_("%s"), err->message);
421+
g_signal_connect(G_OBJECT(widget), "response", G_CALLBACK(gtk_widget_destroy), NULL);
422+
gtk_widget_show(widget);
419423
return;
420424
}
421425

@@ -433,14 +437,10 @@ remmina_plugin_ssh_vte_save_session (GtkMenuItem *menuitem, RemminaProtocolWidge
433437
_("Terminal content saved under"),
434438
g_file_get_path(gpdata->vte_session_file));
435439
}
436-
else
437-
{
438-
439-
remmina_plugin_service->protocol_plugin_set_error (gp, "%s", err);
440-
}
441440

442-
g_free(err);
443441
g_object_unref(stream);
442+
g_free(err);
443+
444444
}
445445

446446
/* Send a keystroke to the plugin window */

0 commit comments

Comments
 (0)