'Connect' button on profile editor must not save settings and pwd

Author: giox069

remmina/src/remmina_file.c

@@ -79,6 +79,7 @@ remmina_file_new_empty(void)
 	 * it's used by remmina_file_store_secret_plugin_password() to know
 	 * where to change */
 	remminafile->spsettings = g_hash_table_new_full(g_str_hash, g_str_equal, g_free, g_free);
+	remminafile->prevent_saving = FALSE;
 	return remminafile;
 }
 
@@ -445,6 +446,9 @@ void remmina_file_save(RemminaFile *remminafile)
 	GKeyFile *gkeyfile;
 	gsize length = 0;
 
+	if (remminafile->prevent_saving)
+		return;
+
 	if ((gkeyfile = remmina_file_get_keyfile(remminafile)) == NULL)
 		return;
 

remmina/src/remmina_file.h

@@ -46,6 +46,7 @@ struct _RemminaFile
 	gchar *filename;
 	GHashTable *settings;
 	GHashTable *spsettings;
+	gboolean prevent_saving;
 };
 
 enum

remmina/src/remmina_file_editor.c

@@ -1250,6 +1250,7 @@ static void remmina_file_editor_on_connect(GtkWidget* button, RemminaFileEditor*
 		remmina_file_set_string(gf, "name", remmina_file_get_string(gf, "server"));
 	}
 	gtk_widget_destroy(GTK_WIDGET(gfe));
+	gf->prevent_saving = TRUE;
 	remmina_connection_window_open_from_file(gf);
 }
 

remmina/src/remmina_protocol_widget.c

@@ -1031,11 +1031,12 @@ gint remmina_protocol_widget_init_authpwd(RemminaProtocolWidget* gp, RemminaAuth
 		s = g_strdup(_("Password"));
 		break;
 	}
+
 	ret = remmina_init_dialog_authpwd(
 	          REMMINA_INIT_DIALOG(gp->priv->init_dialog),
 	          s,
-	          remmina_file_get_filename(remminafile) != NULL &&
-	          allow_password_saving);
+	          (remmina_file_get_filename(remminafile) != NULL &&
+				!remminafile->prevent_saving && allow_password_saving));
 	g_free(s);
 
 	return ret;
@@ -1051,7 +1052,8 @@ gint remmina_protocol_widget_init_authuserpwd(RemminaProtocolWidget* gp, gboolea
 	           want_domain,
 	           remmina_file_get_string(remminafile, "username"),
 	           want_domain ? remmina_file_get_string(remminafile, "domain") : NULL,
-	           (remmina_file_get_filename(remminafile) != NULL) && allow_password_saving);
+	           (remmina_file_get_filename(remminafile) != NULL &&
+					!remminafile->prevent_saving && allow_password_saving));
 }
 
 gint remmina_protocol_widget_init_certificate(RemminaProtocolWidget* gp, const gchar* subject, const gchar* issuer, const gchar* fingerprint)