Skip to content

Commit 9b217b4

Browse files
authored
Merge pull request #1553 from FreeRDP/sshwifi
TCP_USER_TIMEOUT is in milliseconds. Closes #1487 and #975
2 parents 7c07949 + e96046b commit 9b217b4

1 file changed

Lines changed: 6 additions & 7 deletions

File tree

remmina/src/remmina_ssh.c

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -95,10 +95,9 @@
9595
#endif
9696

9797
#define SSH_SOCKET_TCP_KEEPIDLE 20
98-
#define SSH_SOCKET_TCP_KEEPCNT 3
9998
#define SSH_SOCKET_TCP_KEEPINTVL 10
100-
/* Remember to lower SSH_SOCKET_TCP_USER_TIMEOUT to 4 when kernel bug 108191 will be fixed */
101-
#define SSH_SOCKET_TCP_USER_TIMEOUT 9
99+
#define SSH_SOCKET_TCP_KEEPCNT 3
100+
#define SSH_SOCKET_TCP_USER_TIMEOUT 60000 // 60 seconds
102101
#endif
103102

104103
/*-----------------------------------------------------------------------------*
@@ -576,25 +575,25 @@ remmina_ssh_init_session(RemminaSSH *ssh)
576575
}
577576
#ifdef TCP_KEEPIDLE
578577
optval = SSH_SOCKET_TCP_KEEPIDLE;
579-
if (setsockopt(sshsock, IPPROTO_TCP, TCP_KEEPIDLE, &optval, sizeof(optval)) < 0) {
578+
if (setsockopt(sshsock, IPPROTO_TCP, TCP_KEEPIDLE, &optval, sizeof(optval)) < 0) {
580579
remmina_log_printf("[SSH] TCP_KEEPIDLE not set\n");
581580
}
582581
#endif
583582
#ifdef TCP_KEEPCNT
584583
optval = SSH_SOCKET_TCP_KEEPCNT;
585-
if (setsockopt(sshsock, IPPROTO_TCP, TCP_KEEPCNT, &optval, sizeof(optval)) < 0) {
584+
if (setsockopt(sshsock, IPPROTO_TCP, TCP_KEEPCNT, &optval, sizeof(optval)) < 0) {
586585
remmina_log_printf("[SSH] TCP_KEEPCNT not set\n");
587586
}
588587
#endif
589588
#ifdef TCP_KEEPINTVL
590589
optval = SSH_SOCKET_TCP_KEEPINTVL;
591-
if (setsockopt(sshsock, IPPROTO_TCP, TCP_KEEPINTVL, &optval, sizeof(optval)) < 0) {
590+
if (setsockopt(sshsock, IPPROTO_TCP, TCP_KEEPINTVL, &optval, sizeof(optval)) < 0) {
592591
remmina_log_printf("[SSH] TCP_KEEPINTVL not set\n");
593592
}
594593
#endif
595594
#ifdef TCP_USER_TIMEOUT
596595
optval = SSH_SOCKET_TCP_USER_TIMEOUT;
597-
if (setsockopt(sshsock, IPPROTO_TCP, TCP_USER_TIMEOUT, &optval, sizeof(optval)) < 0) {
596+
if (setsockopt(sshsock, IPPROTO_TCP, TCP_USER_TIMEOUT, &optval, sizeof(optval)) < 0) {
598597
remmina_log_printf("[SSH] TCP_USER_TIMEOUT not set\n");
599598
}
600599
#endif

0 commit comments

Comments
 (0)