g_date_time_unref only ath the end of the iteration and if not NULL

Author: antenore

remmina/src/remmina_stats.c

@@ -584,17 +584,11 @@ static void remmina_profiles_get_data(RemminaFile *remminafile, gpointer user_da
 					//remmina_log_printf("Date %s is newer than the one inside pdata->protocol for protocol %s\n", g_strdup(pdata->pdatestr), g_strdup(pdata->protocol));
 					g_hash_table_replace(pdata->proto_date, g_strdup(pdata->protocol), g_strdup(pdata->pdatestr));
 				}
-				g_date_time_unref(ds);
-			}
-			/** If the date in the hash is valid and the date in the profile is NULL we keep the first one */
-			if (ds && !dd) {
-				g_date_time_unref(ds);
 			}
 			/** If the date in the hash is NOT valid and the date in the profile is valid we keep the latter */
 			if (!ds && dd) {
 				//remmina_log_printf("Date %s inserted in pdata->protocol for protocol %s\n", g_strdup(pdata->pdatestr), g_strdup(pdata->protocol));
 				g_hash_table_replace(pdata->proto_date, g_strdup(pdata->protocol), g_strdup(pdata->pdatestr));
-				g_date_time_unref(ds);
 			}
 			/** If both date are NULL, we insert NULL for that protocol */
 			if ((!ds && !dd) && pdata->pdatestr) {
@@ -613,9 +607,11 @@ static void remmina_profiles_get_data(RemminaFile *remminafile, gpointer user_da
 				g_hash_table_replace(pdata->proto_date, g_strdup(pdata->protocol), NULL);
 			}
 		}
-		if (dd)
-			g_date_time_unref(dd);
 	}
+	if (dd)
+		g_date_time_unref(dd);
+	if (ds)
+		g_date_time_unref(ds);
 }
 
 /**

remmina/ui/remmina_main.glade

@@ -1,8 +1,8 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<!-- Generated with glade 3.20.2 
+<!-- Generated with glade 3.20.0 
 
 Remmina - The GTK+ Remmina Remote Desktop Client
-Copyright (C) Antenore Gatta & Giovanni Panozzo 2014-2017
+Copyright (C) Antenore Gatta & Giovanni Panozzo 2014-2018
 
 This program is free software; you can redistribute it and/or
 modify it under the terms of the GNU General Public License
@@ -24,7 +24,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
   <!-- interface-license-type gplv2 -->
   <!-- interface-name Remmina -->
   <!-- interface-description The GTK+ Remmina Remote Desktop Client -->
-  <!-- interface-copyright Antenore Gatta & Giovanni Panozzo 2014-2017 -->
+  <!-- interface-copyright Antenore Gatta & Giovanni Panozzo 2014-2018 -->
   <object class="GtkAccelGroup" id="accelgroup_shortcuts"/>
   <object class="GtkActionGroup" id="actiongroup_application">
     <property name="accel_group">accelgroup_shortcuts</property>