Skip to content

Commit 71cb7a1

Browse files
committed
Fix crash when deleting profile for nonexistent plugin
1 parent cd526ef commit 71cb7a1

1 file changed

Lines changed: 18 additions & 18 deletions

File tree

remmina/src/remmina_file.c

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -569,28 +569,28 @@ void remmina_file_unsave_password(RemminaFile *remminafile)
569569
proto = (gchar*)g_hash_table_lookup(remminafile->settings, "protocol");
570570
if (proto) {
571571
protocol_plugin = (RemminaProtocolPlugin*)remmina_plugin_manager_get_plugin(REMMINA_PLUGIN_TYPE_PROTOCOL, proto);
572-
}
573-
574-
setting_iter = protocol_plugin->basic_settings;
575-
if (setting_iter) {
576-
while (setting_iter->type != REMMINA_PROTOCOL_SETTING_TYPE_END) {
577-
if (is_encrypted_setting(setting_iter)) {
578-
remmina_file_set_string(remminafile, remmina_plugin_manager_get_canonical_setting_name(setting_iter), NULL);
572+
if (protocol_plugin) {
573+
setting_iter = protocol_plugin->basic_settings;
574+
if (setting_iter) {
575+
while (setting_iter->type != REMMINA_PROTOCOL_SETTING_TYPE_END) {
576+
if (is_encrypted_setting(setting_iter)) {
577+
remmina_file_set_string(remminafile, remmina_plugin_manager_get_canonical_setting_name(setting_iter), NULL);
578+
}
579+
setting_iter++;
580+
}
579581
}
580-
setting_iter++;
581-
}
582-
}
583-
setting_iter = protocol_plugin->advanced_settings;
584-
if (setting_iter) {
585-
while (setting_iter->type != REMMINA_PROTOCOL_SETTING_TYPE_END) {
586-
if (is_encrypted_setting(setting_iter)) {
587-
remmina_file_set_string(remminafile, remmina_plugin_manager_get_canonical_setting_name(setting_iter), NULL);
582+
setting_iter = protocol_plugin->advanced_settings;
583+
if (setting_iter) {
584+
while (setting_iter->type != REMMINA_PROTOCOL_SETTING_TYPE_END) {
585+
if (is_encrypted_setting(setting_iter)) {
586+
remmina_file_set_string(remminafile, remmina_plugin_manager_get_canonical_setting_name(setting_iter), NULL);
587+
}
588+
setting_iter++;
589+
}
588590
}
589-
setting_iter++;
591+
remmina_file_save(remminafile);
590592
}
591593
}
592-
593-
remmina_file_save(remminafile);
594594
}
595595

596596
/**

0 commit comments

Comments
 (0)