Skip to content

Commit db672b1

Browse files
authored
Merge pull request #30 from daniellienert/bugfix/no-serialization
BUGFIX: (Un)serializiation is not needed when using VariableFrontend Closes: #28
2 parents 279ee75 + 5a5e8be commit db672b1

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

Classes/Command/JobCommandController.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ public function executeCommand($queue, $messageCacheIdentifier)
154154
}
155155

156156
/** @var Message $message */
157-
$message = unserialize($this->messageCache->get($messageCacheIdentifier));
157+
$message = $this->messageCache->get($messageCacheIdentifier);
158158
$queue = $this->queueManager->getQueue($queue);
159159
$this->jobManager->executeJobForMessage($queue, $message);
160160
}

Classes/Job/JobManager.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public function waitAndExecute($queueName, $timeout = null)
100100
try {
101101
if (isset($queueSettings['executeIsolated']) && $queueSettings['executeIsolated'] === true) {
102102
$messageCacheIdentifier = sha1(serialize($message));
103-
$this->messageCache->set($messageCacheIdentifier, serialize($message));
103+
$this->messageCache->set($messageCacheIdentifier, $message);
104104
Scripts::executeCommand('flowpack.jobqueue.common:job:execute', $this->flowSettings, false, [$queue->getName(), $messageCacheIdentifier]);
105105
$this->messageCache->remove($messageCacheIdentifier);
106106
} else {

Classes/Queue/FakeQueue.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ public function submit($payload, array $options = [])
8585
$message = new Message($messageId, $payload);
8686

8787
$messageCacheIdentifier = sha1(serialize($message));
88-
$this->messageCache->set($messageCacheIdentifier, serialize($message));
88+
$this->messageCache->set($messageCacheIdentifier, $message);
8989

9090
if ($this->async) {
9191
Scripts::executeCommandAsync('flowpack.jobqueue.common:job:execute', $this->flowSettings, [$this->name, $messageCacheIdentifier]);

0 commit comments

Comments
 (0)