Skip to content

Commit 94118de

Browse files
author
Bernhard Schmitt
committed
Make further nullability explicit
1 parent 3ae5ca6 commit 94118de

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,7 +373,7 @@ class Package extends BasePackage
373373
374374
$dispatcher->connect(
375375
JobManager::class, 'messageFailed',
376-
function(QueueInterface $queue, Message $message, \Exception $jobExecutionException = null) use ($bootstrap) {
376+
function(QueueInterface $queue, Message $message, ?\Exception $jobExecutionException = null) use ($bootstrap) {
377377
$additionalData = [
378378
'queue' => $queue->getName(),
379379
'message' => $message->getIdentifier()

Tests/Unit/Fixtures/TestQueue.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ public function submit($payload, array $options = []): string
115115
/**
116116
* @inheritdoc
117117
*/
118-
public function waitAndTake(int $timeout = null): ?Message
118+
public function waitAndTake(?int $timeout = null): ?Message
119119
{
120120
$message = $this->reserveMessage($timeout);
121121
if ($message === null) {
@@ -129,16 +129,16 @@ public function waitAndTake(int $timeout = null): ?Message
129129
/**
130130
* @inheritdoc
131131
*/
132-
public function waitAndReserve(int $timeout = null): ?Message
132+
public function waitAndReserve(?int $timeout = null): ?Message
133133
{
134134
return $this->reserveMessage($timeout);
135135
}
136136

137137
/**
138-
* @param int $timeout
138+
* @param int|null $timeout
139139
* @return Message
140140
*/
141-
protected function reserveMessage(int $timeout = null): ?Message
141+
protected function reserveMessage(?int $timeout = null): ?Message
142142
{
143143
if ($timeout === null) {
144144
$timeout = $this->defaultTimeout;

0 commit comments

Comments
 (0)