TASK: Remove duplicate Elasticsearch check

kdambekalns · web-flow · commit 0b2d939a1713 · 2018-02-07T16:15:51.000+01:00
The check in `extractSuggestions` is not needed, the method

- as such does not rely on Elasticsearch
- will not be called unless Elasticsearch is used (check in `indexAction`)
diff --git a/Classes/Controller/SuggestController.php b/Classes/Controller/SuggestController.php
@@ -178,10 +178,8 @@ protected function extractCompletions($response)
      */
     protected function extractSuggestions($response)
     {
-        if ($this->elasticSearchClient === null) {
-            throw new \RuntimeException('The SuggestController needs an ElasticSearchClient, it seems you run without the flowpack/elasticsearch-contentrepositoryadaptor package, though.', 1487189823);
-        }
         $suggestionOptions = isset($response['suggest']) ? $response['suggest'] : [];
+
         if (count($suggestionOptions['suggestions'][0]['options']) > 0) {
             return $suggestionOptions['suggestions'][0]['options'];
         }

Original file line number	Diff line number	Diff line change
`@@ -178,10 +178,8 @@ protected function extractCompletions($response)`
`178`	`178`	`*/`
`179`	`179`	`protected function extractSuggestions($response)`
`180`	`180`	`{`
`181`		`- if ($this->elasticSearchClient === null) {`
`182`		`- throw new \RuntimeException('The SuggestController needs an ElasticSearchClient, it seems you run without the flowpack/elasticsearch-contentrepositoryadaptor package, though.', 1487189823);`
`183`		`- }`
`184`	`181`	`$suggestionOptions = isset($response['suggest']) ? $response['suggest'] : [];`
	`182`	`+`
`185`	`183`	`if (count($suggestionOptions['suggestions'][0]['options']) > 0) {`
`186`	`184`	`return $suggestionOptions['suggestions'][0]['options'];`
`187`	`185`	`}`