FEATURE: raise prunner version to 0.2.0, make debuggability easier

Author: skurfuerst

Classes/Command/PrunnerCommandController.php

@@ -12,6 +12,9 @@ class PrunnerCommandController extends CommandController
     private const COMPOSER_INSTALL_CMD_KEY = 'post-install-cmd';
     private const COMPOSER_UPDATE_CMD_KEY = 'post-update-cmd';
 
+    /**
+     * Patch project's composer.json file to install prunner binaries on "composer install"
+     */
     public function setupProjectCommand()
     {
         $cmd = InstallerScripts::class . '::postUpdateAndInstall';

Classes/Composer/InstallerScripts.php

@@ -35,7 +35,7 @@ public static function postUpdateAndInstall(Event $event)
         $platform = php_uname('s'); // stuff like Darwin etc
         $architecture = php_uname('m'); // x86_64
 
-        $version = '0.1.0';
+        $version = '0.2.0';
 
         $baseDirectory = 'prunner';
         $platformSpecificTargetDirectory = $baseDirectory . '/' . $platform . '_' . $architecture;

Classes/Dto/Job.php

@@ -26,23 +26,39 @@ class Job
     private array $variables;
     private string $user;
 
+    private function __construct(string $id, string $pipeline, TaskResults $taskResults, bool $completed, bool $canceled, bool $errored, \DateTimeImmutable $created, ?\DateTimeImmutable $start, ?\DateTimeImmutable $end, ?string $lastError, array $variables, string $user)
+    {
+        $this->id = $id;
+        $this->pipeline = $pipeline;
+        $this->taskResults = $taskResults;
+        $this->completed = $completed;
+        $this->canceled = $canceled;
+        $this->errored = $errored;
+        $this->created = $created;
+        $this->start = $start;
+        $this->end = $end;
+        $this->lastError = $lastError;
+        $this->variables = $variables;
+        $this->user = $user;
+    }
+
+
     public static function fromJsonArray(array $in): self
     {
-        $job = new static();
-        $job->id = $in['id'];
-        $job->pipeline = $in['pipeline'];
-        $job->taskResults = TaskResults::fromJsonArray($in['tasks']);;
-        $job->completed = $in['completed'];
-        $job->canceled = $in['canceled'];
-        $job->errored = $in['errored'];
-        $job->created = \DateTimeImmutable::createFromFormat(\DateTimeInterface::W3C, $in['created']);
-        $job->start = isset($in['start']) ? \DateTimeImmutable::createFromFormat(\DateTimeInterface::W3C, $in['start']) : null;
-        $job->end = isset($in['end']) ? \DateTimeImmutable::createFromFormat(\DateTimeInterface::W3C, $in['end']) : null;
-        $job->lastError = $in['lastError'];
-        $job->variables = $in['variables'] ?? [];
-        $job->user = $in['user'];
-
-        return $job;
+        return new self(
+            $in['id'],
+            $in['pipeline'],
+            TaskResults::fromJsonArray($in['tasks']),
+            $in['completed'],
+            $in['canceled'],
+            $in['errored'],
+            \DateTimeImmutable::createFromFormat(\DateTimeInterface::W3C, $in['created']),
+            isset($in['start']) ? \DateTimeImmutable::createFromFormat(\DateTimeInterface::W3C, $in['start']) : null,
+            isset($in['end']) ? \DateTimeImmutable::createFromFormat(\DateTimeInterface::W3C, $in['end']) : null,
+            $in['lastError'] ?? '',
+            $in['variables'] ?? [],
+            $in['user']
+        );
     }
 
     /**

Classes/Dto/TaskResult.php

@@ -19,19 +19,31 @@ class TaskResult
     private bool $errored;
     private ?string $error;
 
+    private function __construct(string $name, string $status, ?\DateTimeImmutable $start, ?\DateTimeImmutable $end, bool $skipped, int $exitCode, bool $errored, ?string $error)
+    {
+        $this->name = $name;
+        $this->status = $status;
+        $this->start = $start;
+        $this->end = $end;
+        $this->skipped = $skipped;
+        $this->exitCode = $exitCode;
+        $this->errored = $errored;
+        $this->error = $error;
+    }
+
+
     public static function fromJsonArray(array $in): self
     {
-        $taskResult = new static();
-        $taskResult->name = $in['name'];
-        $taskResult->status = $in['status'];
-        $taskResult->start = isset($in['start']) ? \DateTimeImmutable::createFromFormat(\DateTimeInterface::RFC3339, $in['start']) : null;
-        $taskResult->end = isset($in['end']) ? \DateTimeImmutable::createFromFormat(\DateTimeInterface::RFC3339, $in['end']) : null;
-        $taskResult->skipped = $in['skipped'];
-        $taskResult->exitCode = $in['exitCode'];
-        $taskResult->errored = $in['errored'];
-        $taskResult->error = $in['error'];
-
-        return $taskResult;
+        return new self(
+            $in['name'],
+            $in['status'],
+            isset($in['start']) ? \DateTimeImmutable::createFromFormat(\DateTimeInterface::RFC3339, $in['start']) : null,
+            isset($in['end']) ? \DateTimeImmutable::createFromFormat(\DateTimeInterface::RFC3339, $in['end']) : null,
+            $in['skipped'],
+            $in['exitCode'],
+            $in['errored'],
+            $in['error'] ?? ''
+        );
     }
 
     /**

Classes/PrunnerApiService.php

@@ -8,7 +8,6 @@
 use Flowpack\Prunner\ValueObject\JobId;
 use Flowpack\Prunner\ValueObject\PipelineName;
 use GuzzleHttp\Client;
-use GuzzleHttp\Psr7\Response;
 use Neos\Flow\Annotations as Flow;
 use Psr\Http\Message\ResponseInterface;
 use Symfony\Component\Yaml\Exception\ParseException;