BUGFIX: support empty job details

skurfuerst · skurfuerst · commit 72c9d5a77ac6 · 2021-08-19T14:27:41.000+02:00
diff --git a/Classes/PrunnerApiService.php b/Classes/PrunnerApiService.php
@@ -51,10 +51,13 @@ public function loadPipelinesAndJobs(): PipelinesAndJobsResponse
         return PipelinesAndJobsResponse::fromJsonArray($result);
     }
 
-    public function loadJobDetail(JobId $jobId): Job
+    public function loadJobDetail(JobId $jobId): ?Job
     {
         $resultString = $this->apiCall('GET', 'job/detail?' . http_build_query(['id' => $jobId->getId()]), null)->getBody()->getContents();
         $result = json_decode($resultString, true);
+        if (isset($result['error'])) {
+            return null;
+        }
         return Job::fromJsonArray($result);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -51,10 +51,13 @@ public function loadPipelinesAndJobs(): PipelinesAndJobsResponse`
`51`	`51`	`return PipelinesAndJobsResponse::fromJsonArray($result);`
`52`	`52`	`}`
`53`	`53`
`54`		`- public function loadJobDetail(JobId $jobId): Job`
	`54`	`+ public function loadJobDetail(JobId $jobId): ?Job`
`55`	`55`	`{`
`56`	`56`	`$resultString = $this->apiCall('GET', 'job/detail?' . http_build_query(['id' => $jobId->getId()]), null)->getBody()->getContents();`
`57`	`57`	`$result = json_decode($resultString, true);`
	`58`	`+ if (isset($result['error'])) {`
	`59`	`+ return null;`
	`60`	`+ }`
`58`	`61`	`return Job::fromJsonArray($result);`
`59`	`62`	`}`
`60`	`63`