chore: Mark some free standing functions static

If free standing functions are only ever used in one
compile unit, they should be marked `static` to not pollute
the namespace during linking.

Author: ChristianTackeGSI

examples/MQ/pixelDetector/src/PixelDigiSource.cxx

@@ -1,5 +1,5 @@
 /********************************************************************************
- * Copyright (C) 2014-2023 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH  *
+ * Copyright (C) 2014-2024 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH  *
  *                                                                              *
  *              This software is distributed under the terms of the             *
  *              GNU Lesser General Public Licence (LGPL) version 3,             *
@@ -64,7 +64,7 @@ Bool_t PixelDigiSource::Init()
     return kTRUE;
 }
 
-int ReadIntFromString(const std::string& wholestr, const std::string& pattern)
+static int ReadIntFromString(const std::string& wholestr, const std::string& pattern)
 {
     std::string tempstr = wholestr;
     tempstr.replace(0, tempstr.find(pattern) + pattern.length(), "");

examples/MQ/serialization/data_generator/dataGenerator.cxx

@@ -1,5 +1,5 @@
 /********************************************************************************
- * Copyright (C) 2023 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH       *
+ * Copyright (C) 2023-2024 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH  *
  *                                                                              *
  *              This software is distributed under the terms of the             *
  *              GNU Lesser General Public Licence (LGPL) version 3,             *
@@ -40,7 +40,7 @@ using std::string;
 using std::vector;
 
 // fill data payload and save to file
-void SaveDataToFile(RootOutFileManager<MyDigi>& outMan, RooDataSet& dataset)
+static void SaveDataToFile(RootOutFileManager<MyDigi>& outMan, RooDataSet& dataset)
 {
     vector<MyDigi> dataBunch;
     dataBunch.reserve(dataset.numEntries());

fairroot/base/event/FairMultiLinkedData.cxx

@@ -1,5 +1,5 @@
 /********************************************************************************
- * Copyright (C) 2014-2023 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH  *
+ * Copyright (C) 2014-2024 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH  *
  *                                                                              *
  *              This software is distributed under the terms of the             *
  *              GNU Lesser General Public Licence (LGPL) version 3,             *
@@ -284,7 +284,10 @@ FairMultiLinkedData FairMultiLinkedData::GetLinksWithType(Int_t type) const
     return result;
 }
 
-bool LargerWeight(FairLink val1, FairLink val2) { return val1.GetWeight() > val2.GetWeight(); }
+static bool LargerWeight(FairLink const& val1, FairLink const& val2)
+{
+    return val1.GetWeight() > val2.GetWeight();
+}
 
 std::vector<FairLink> FairMultiLinkedData::GetSortedMCTracks()
 {

fairroot/base/steer/FairRunAna.cxx

@@ -1,5 +1,5 @@
 /********************************************************************************
- * Copyright (C) 2014-2023 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH  *
+ * Copyright (C) 2014-2024 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH  *
  *                                                                              *
  *              This software is distributed under the terms of the             *
  *              GNU Lesser General Public Licence (LGPL) version 3,             *
@@ -46,10 +46,10 @@
 using std::cout;
 using std::endl;
 
-Bool_t gFRAIsInterrupted;
+static Bool_t gFRAIsInterrupted;
 
 //_____________________________________________________________________________
-void FRA_handler_ctrlc(int)
+static void FRA_handler_ctrlc(int)
 {
     LOG(info) << "*********** CTRL C PRESSED *************";
     gFRAIsInterrupted = kTRUE;

fairroot/online/steer/FairRunOnline.cxx

@@ -1,5 +1,5 @@
 /********************************************************************************
- * Copyright (C) 2014-2023 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH  *
+ * Copyright (C) 2014-2024 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH  *
  *                                                                              *
  *              This software is distributed under the terms of the             *
  *              GNU Lesser General Public Licence (LGPL) version 3,             *
@@ -97,9 +97,9 @@ FairRunOnline::~FairRunOnline()
     }
 }
 
-Bool_t gIsInterrupted;
+static Bool_t gIsInterrupted;
 
-void handler_ctrlc(int)
+static void handler_ctrlc(int)
 {
     gIsInterrupted = kTRUE;
 }