fix(eventdisplay): Fix wrong init order.

Author: DanielWielanek

examples/advanced/propagator/src/FairEveRecoTracksExample.cxx

@@ -1,5 +1,5 @@
 /********************************************************************************
- *    Copyright (C) 2020 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH    *
+ * Copyright (C) 2020-2023 GSI Helmholtzzentrum fuer Schwerionenforschung GmbH  *
  *                                                                              *
  *              This software is distributed under the terms of the             *
  *              GNU Lesser General Public Licence (LGPL) version 3,             *
@@ -18,6 +18,7 @@
 
 #include "FairEveRecoTrack.h"
 #include "FairEveTrack.h"
+#include "FairEventManager.h"
 #include "FairField.h"
 #include "FairHit.h"
 #include "FairMCTrack.h"
@@ -194,19 +195,22 @@ void FairEveRecoTracksExample::Repaint()
 
 InitStatus FairEveRecoTracksExample::Init()
 {
-    FairRootManager *mngr = FairRootManager::Instance();
-    fContainerReco = (TClonesArray *)mngr->GetObject("FairTutPropTracks");
+    auto status = FairEveTracks::Init();
+    if (status != kSUCCESS)
+        return status;
+    FairRootManager& mngr = GetEventManager()->GetRootManager();
+    fContainerReco = dynamic_cast<TClonesArray*>(mngr.GetObject("FairTutPropTracks"));
     if (fContainerReco == nullptr) {
         LOG(error) << "Reco traks not found";
         return kFATAL;
     }
-    fHits1 = (TClonesArray *)mngr->GetObject("FairTutPropHits");
-    fHits2 = (TClonesArray *)mngr->GetObject("FairTutPropHits2");
+    fHits1 = dynamic_cast<TClonesArray*>(mngr.GetObject("FairTutPropHits"));
+    fHits2 = dynamic_cast<TClonesArray*>(mngr.GetObject("FairTutPropHits2"));
     if (fHits1 == nullptr || fHits2 == nullptr) {
         LOG(error) << "Hits not found";
         return kFATAL;
     }
-    fContainerSim = (TClonesArray *)mngr->GetObject("MCTrack");
+    fContainerSim = dynamic_cast<TClonesArray*>(mngr.GetObject("MCTrack"));
     if (fContainerSim == nullptr) {
         LOG(warning) << "No branch with MC tracks";
     }
@@ -218,7 +222,7 @@ InitStatus FairEveRecoTracksExample::Init()
     }
     fRK = new FairRKPropagator(field);
     fPDG = TDatabasePDG::Instance();
-    return FairEveTracks::Init();
+    return kSUCCESS;
 }
 
 void FairEveRecoTracksExample::SetDrawMC(Bool_t draw)

examples/common/eventdisplay/FairEveMCTracks.cxx

@@ -145,6 +145,9 @@ void FairEveMCTracks::Repaint()
 
 InitStatus FairEveMCTracks::Init()
 {
+    auto status = FairEveTracks::Init();
+    if (status != kSUCCESS)
+        return status;
     FairEventManager* eveManager = GetEventManager();
     FairRootManager* mngr = &(eveManager->GetRootManager());
     fContainer = dynamic_cast<TClonesArray*>(mngr->GetObject("MCTrack"));
@@ -165,7 +168,7 @@ InitStatus FairEveMCTracks::Init()
     }
     fRK = std::make_unique<FairRKPropagator>(field);
     fPDG = TDatabasePDG::Instance();
-    return FairEveTracks::Init();
+    return kSUCCESS;
 }
 
 FairEveMCTracks::~FairEveMCTracks() = default;

fairroot/eventdisplay/tracks/FairEveGeoTracks.cxx

@@ -47,6 +47,9 @@ FairEveGeoTracks::FairEveGeoTracks()
 
 InitStatus FairEveGeoTracks::Init()
 {
+    auto status = FairEveTracks::Init();
+    if (status != kSUCCESS)
+        return status;
     FairEventManager* eveManager = GetEventManager();
     auto& mngr = eveManager->GetRootManager();
     fContainer = dynamic_cast<TClonesArray*>(mngr.GetObject("GeoTracks"));
@@ -56,7 +59,7 @@ InitStatus FairEveGeoTracks::Init()
     }
     fBranch = mngr.GetInTree()->GetBranch("GeoTracks");
     FairGetEventTime::Instance().Init();
-    return FairEveTracks::Init();
+    return kSUCCESS;
 }
 
 void FairEveGeoTracks::DrawTrack(Int_t id)
@@ -154,15 +157,15 @@ void FairEveGeoTracks::Repaint()
 {
     bool useGeoTrackHandler = false;
     if (FairRunAna::Instance()->IsTimeStamp() && fBranch != nullptr) {
-        Double_t simTime = FairEventManager::Instance()->GetEvtTime();
+        Double_t simTime = GetEventManager()->GetEvtTime();
         std::pair<int, double> evt = FairGetEventTime::Instance().GetEvent(simTime);
 
         if (evt.first < 0) {
             fContainer->Clear();
         } else {
             fBranch->GetEvent(evt.first);
         }
-        if (FairEventManager::Instance()->GetClearHandler()) {
+        if (GetEventManager()->GetClearHandler()) {
             fGeoTrackHandler.Reset();
         }
         if (evt.first > -1)
@@ -176,7 +179,7 @@ void FairEveGeoTracks::Repaint()
         nTracks = fContainer->GetEntriesFast();
     }
     RemoveElements();
-    FairEventManager::Instance()->GetTimeLimits(fTMin, fTMax);
+    GetEventManager()->GetTimeLimits(fTMin, fTMax);
     if (fTMin > fTMax) {   // wrong time limits draw entire tracks
         for (int iTrack = 0; iTrack < nTracks; iTrack++) {
             DrawTrack(iTrack);