fix some C-Style casts

and check types.

Author: ChristianTackeGSI

examples/MQ/pixelAlternative/src/PixelAltFindHits.cxx

@@ -188,7 +188,10 @@ void PixelAltFindHits::GetParList(TList* tempList)
 void PixelAltFindHits::InitMQ(TList* tempList)
 {
     LOG(info) << "********************************************** PixelAltFindHits::InitMQ()";
-    fDigiPar = (PixelDigiPar*)tempList->FindObject("PixelDigiParameters");
+    fDigiPar = dynamic_cast<PixelDigiPar*>(tempList->FindObject("PixelDigiParameters"));
+    if (!fDigiPar) {
+        throw std::runtime_error("no PixelDigiParameters");
+    }
 
     fFeCols = fDigiPar->GetFECols();
     fFeRows = fDigiPar->GetFERows();
@@ -211,7 +214,13 @@ void PixelAltFindHits::ExecMQ(TList* inputList, TList* outputList)
     //  << "," << outputList->GetName() << "), Event " << fTNofEvents; LOG(info) <<
     //  "********************************************** PixelAltFindHits::ExecMQ(), Event " << fTNofEvents; LOG(info) <<
     //  "h" << FairLogger::flush;
-    fDigis = (TClonesArray*)inputList->FindObject("PixelDigis");
+    fDigis = dynamic_cast<TClonesArray*>(inputList->FindObject("PixelDigis"));
+    if (!fDigis) {
+        throw std::runtime_error("no PixelDigis");
+    }
+    if (!fDigis->GetClass()->InheritsFrom(PixelDigi::Class())) {
+        throw std::runtime_error("wrong type in PixelDigis TCA");
+    }
     outputList->Add(fHits);
     Exec("");
 }

examples/MQ/pixelDetector/src/PixelDigiBinSource.cxx

@@ -83,7 +83,7 @@ Int_t PixelDigiBinSource::ReadEvent(UInt_t i)
     LOG(debug) << "PixelDigiBinSource::ReadEvent() Begin of (" << fDigis.GetEntries() << ")";
 
     Int_t head[4];   // runId, MCEntryNo, PartNo, NofDigis
-    fInputFile.read((char*)head, sizeof(head));
+    fInputFile.read(reinterpret_cast<char*>(head), sizeof(head));
 
     if (fInputFile.eof()) {
         LOG(info) << "End of file reached!";
@@ -94,7 +94,7 @@ Int_t PixelDigiBinSource::ReadEvent(UInt_t i)
 
     const Int_t constNofData = head[3] * dataSize;
     short int dataCont[constNofData];
-    fInputFile.read((char*)dataCont, sizeof(dataCont));
+    fInputFile.read(reinterpret_cast<char*>(dataCont), sizeof(dataCont));
 
     fRunId = head[0];
     fMCEntryNo = head[1];
@@ -146,7 +146,7 @@ Int_t PixelDigiBinSource::CheckMaxEventNo(Int_t /*EvtEnd*/) { return -1; }
 
 void PixelDigiBinSource::FillEventHeader(FairEventHeader* feh)
 {
-    ((PixelEventHeader*)feh)->SetRunId(fRunId);
-    ((PixelEventHeader*)feh)->SetMCEntryNumber(fMCEntryNo);
-    ((PixelEventHeader*)feh)->SetPartNo(fPartNo);
+    FairSource::FillEventHeader(feh);
+    feh->SetMCEntryNumber(fMCEntryNo);
+    static_cast<PixelEventHeader*>(feh)->SetPartNo(fPartNo);
 }

examples/MQ/pixelDetector/src/PixelDigiSource.cxx

@@ -144,7 +144,7 @@ Int_t PixelDigiSource::CheckMaxEventNo(Int_t /*EvtEnd*/) { return -1; }
 
 void PixelDigiSource::FillEventHeader(FairEventHeader* feh)
 {
-    ((PixelEventHeader*)feh)->SetRunId(fRunId);
-    ((PixelEventHeader*)feh)->SetMCEntryNumber(fMCEntryNo);
-    ((PixelEventHeader*)feh)->SetPartNo(fPartNo);
+    FairSource::FillEventHeader(feh);
+    feh->SetMCEntryNumber(fMCEntryNo);
+    static_cast<PixelEventHeader*>(feh)->SetPartNo(fPartNo);
 }

examples/MQ/pixelDetector/src/PixelDigitize.cxx

@@ -183,7 +183,10 @@ void PixelDigitize::GetParList(TList* tempList)
 void PixelDigitize::InitMQ(TList* tempList)
 {
     LOG(info) << "********************************************** PixelDigitize::InitMQ()";
-    fDigiPar = (PixelDigiPar*)tempList->FindObject("PixelDigiParameters");
+    fDigiPar = dynamic_cast<PixelDigiPar*>(tempList->FindObject("PixelDigiParameters"));
+    if (!fDigiPar) {
+        throw std::runtime_error("no PixelDigiParameters");
+    }
 
     fFeCols = fDigiPar->GetFECols();
     fFeRows = fDigiPar->GetFERows();
@@ -205,7 +208,13 @@ void PixelDigitize::ExecMQ(TList* inputList, TList* outputList)
     //  LOG(info) << "********************************************** PixelDigitize::ExecMQ(" << inputList->GetName() <<
     //  "," << outputList->GetName() << "), Event " << fTNofEvents; LOG(info) <<
     //  "********************************************** PixelDigitize::ExecMQ(), Event " << fTNofEvents;
-    fPoints = (TClonesArray*)inputList->FindObject("PixelPoint");
+    fPoints = dynamic_cast<TClonesArray*>(inputList->FindObject("PixelPoint"));
+    if (!fPoints) {
+        throw std::runtime_error("no PixelPoint");
+    }
+    if (!fPoints->GetClass()->InheritsFrom(PixelPoint::Class())) {
+        throw std::runtime_error("wrong type in PixelPoint TCA");
+    }
     outputList->Add(fDigis);
     Exec("");
 }

examples/MQ/pixelDetector/src/PixelFindHits.cxx

@@ -151,7 +151,10 @@ void PixelFindHits::GetParList(TList* tempList)
 void PixelFindHits::InitMQ(TList* tempList)
 {
     LOG(info) << "********************************************** PixelFindHits::InitMQ()";
-    fDigiPar = (PixelDigiPar*)tempList->FindObject("PixelDigiParameters");
+    fDigiPar = dynamic_cast<PixelDigiPar*>(tempList->FindObject("PixelDigiParameters"));
+    if (!fDigiPar) {
+        throw std::runtime_error("no PixelDigiParameters");
+    }
 
     fFeCols = fDigiPar->GetFECols();
     fFeRows = fDigiPar->GetFERows();
@@ -174,7 +177,13 @@ void PixelFindHits::ExecMQ(TList* inputList, TList* outputList)
     //  "," << outputList->GetName() << "), Event " << fTNofEvents; LOG(info) <<
     //  "********************************************** PixelFindHits::ExecMQ(), Event " << fTNofEvents; LOG(info) <<
     //  "h" << FairLogger::flush;
-    fDigis = (TClonesArray*)inputList->FindObject("PixelDigis");
+    fDigis = dynamic_cast<TClonesArray*>(inputList->FindObject("PixelDigis"));
+    if (!fDigis) {
+        throw std::runtime_error("no PixelDigis");
+    }
+    if (!fDigis->GetClass()->InheritsFrom(PixelDigi::Class())) {
+        throw std::runtime_error("wrong type in PixelDigis TCA");
+    }
     outputList->Add(fHits);
     Exec("");
 }

examples/MQ/pixelDetector/src/PixelFindTracks.cxx

@@ -156,7 +156,10 @@ void PixelFindTracks::GetParList(TList* tempList)
 void PixelFindTracks::InitMQ(TList* tempList)
 {
     LOG(info) << "********************************************** PixelFindTracks::InitMQ()";
-    fDigiPar = (PixelDigiPar*)tempList->FindObject("PixelDigiParameters");
+    fDigiPar = dynamic_cast<PixelDigiPar*>(tempList->FindObject("PixelDigiParameters"));
+    if (!fDigiPar) {
+        throw std::runtime_error("no PixelDigiParameters");
+    }
 
     fTracks = new TClonesArray("PixelTrack", 10000);
     fhDist2D = new TH2F("fhDist2D", "Distance between hit and expected track", 400, -1., 1., 400, -1., 1.);
@@ -168,7 +171,13 @@ void PixelFindTracks::ExecMQ(TList* inputList, TList* outputList)
     //  << "," << outputList->GetName() << "), Event " << fTNofEvents; LOG(info) <<
     //  "********************************************** PixelFindTracks::ExecMQ(), Event " << fTNofEvents; LOG(info) <<
     //  "t" << FairLogger::flush;
-    fHits = (TClonesArray*)inputList->FindObject("PixelHits");
+    fHits = dynamic_cast<TClonesArray*>(inputList->FindObject("PixelHits"));
+    if (!fHits) {
+        throw std::runtime_error("no PixelHits");
+    }
+    if (!fHits->GetClass()->InheritsFrom(PixelHit::Class())) {
+        throw std::runtime_error("wrong type in PixelHits TCA");
+    }
     outputList->Add(fTracks);
     Exec("");
 }